-
Notifications
You must be signed in to change notification settings - Fork 373
feat: route arrays_zip on map element types through the codegen dispatcher
#5688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kazantsev-maksim
wants to merge
80
commits into
apache:main
Choose a base branch
from
kazantsev-maksim:arrays_zip_codegen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
768b3e9
impl map_from_entries
c68c342
Revert "impl map_from_entries"
d887555
Merge branch 'apache:main' into main
kazantsev-maksim 231aa90
Merge branch 'apache:main' into main
kazantsev-maksim 9500bbb
Merge branch 'apache:main' into main
kazantsev-maksim 9577481
Merge branch 'apache:main' into main
kazantsev-maksim 3791557
Merge branch 'apache:main' into main
kazantsev-maksim 7c2f082
Merge branch 'apache:main' into main
kazantsev-maksim 609a605
Merge branch 'apache:main' into main
kazantsev-maksim a151b2c
Merge branch 'apache:main' into main
kazantsev-maksim ad3e7f5
Merge branch 'apache:main' into main
kazantsev-maksim ea92e4b
Merge branch 'apache:main' into main
kazantsev-maksim 8dfeca3
Merge branch 'apache:main' into main
kazantsev-maksim 559741e
Merge branch 'apache:main' into main
kazantsev-maksim ebda14e
Merge branch 'apache:main' into main
kazantsev-maksim 408152e
Merge branch 'apache:main' into main
kazantsev-maksim d7857b2
Merge branch 'apache:main' into main
kazantsev-maksim aef41be
Merge branch 'apache:main' into main
kazantsev-maksim 5ac1c58
Merge branch 'apache:main' into main
kazantsev-maksim 9ae8e23
Merge branch 'apache:main' into main
kazantsev-maksim 5ca3888
Merge branch 'apache:main' into main
kazantsev-maksim 160a817
Merge branch 'apache:main' into main
kazantsev-maksim 88fc313
Merge branch 'apache:main' into main
kazantsev-maksim e14c180
Merge branch 'apache:main' into main
kazantsev-maksim 610a885
Merge branch 'apache:main' into main
kazantsev-maksim f8acb2c
Merge branch 'apache:main' into main
kazantsev-maksim ec94897
Merge branch 'apache:main' into main
kazantsev-maksim 43405e4
Merge branch 'apache:main' into main
kazantsev-maksim 47b4915
Merge branch 'apache:main' into main
kazantsev-maksim 26e2682
Merge branch 'apache:main' into main
kazantsev-maksim 6cb5f07
Merge branch 'apache:main' into main
kazantsev-maksim ec194fb
Merge branch 'apache:main' into main
kazantsev-maksim 256fccb
Merge branch 'apache:main' into main
kazantsev-maksim 912c8f9
Merge branch 'apache:main' into main
kazantsev-maksim 561a664
Merge branch 'apache:main' into main
kazantsev-maksim d926ef4
Merge branch 'apache:main' into main
kazantsev-maksim 671412c
Merge branch 'apache:main' into main
kazantsev-maksim c9f52d1
Merge branch 'apache:main' into main
kazantsev-maksim 67f72d9
Merge branch 'apache:main' into main
kazantsev-maksim 314e594
Merge branch 'apache:main' into main
kazantsev-maksim ac8292f
Merge branch 'apache:main' into main
kazantsev-maksim c9c140e
Merge branch 'apache:main' into main
kazantsev-maksim decca58
Merge branch 'apache:main' into main
kazantsev-maksim 0919b33
Merge branch 'apache:main' into main
kazantsev-maksim 7495e21
Merge branch 'apache:main' into main
kazantsev-maksim 0a37a60
Merge branch 'apache:main' into main
kazantsev-maksim abbba84
Merge branch 'apache:main' into main
kazantsev-maksim 6020560
Merge branch 'apache:main' into main
kazantsev-maksim e2bdfb1
Merge branch 'apache:main' into main
kazantsev-maksim 3edfc33
Merge branch 'apache:main' into main
kazantsev-maksim a39e860
Merge branch 'apache:main' into main
kazantsev-maksim e88dd7b
Merge branch 'apache:main' into main
kazantsev-maksim 3e29d37
Merge branch 'apache:main' into main
kazantsev-maksim 4068359
Merge branch 'apache:main' into main
kazantsev-maksim a3cb8de
Merge branch 'apache:main' into main
kazantsev-maksim b33726f
Merge branch 'apache:main' into main
kazantsev-maksim 698f7a1
Merge branch 'apache:main' into main
kazantsev-maksim 18162a6
Merge branch 'apache:main' into main
kazantsev-maksim 6f6eb6f
Merge branch 'apache:main' into main
kazantsev-maksim c21a42e
Merge branch 'apache:main' into main
kazantsev-maksim 618ae48
Merge branch 'apache:main' into main
kazantsev-maksim 4d068e3
Merge branch 'apache:main' into main
kazantsev-maksim a2f519f
Merge branch 'apache:main' into main
kazantsev-maksim 36e13d5
Merge branch 'apache:main' into main
kazantsev-maksim 2c8ae52
Merge branch 'apache:main' into main
kazantsev-maksim 593f7b6
Merge branch 'apache:main' into main
kazantsev-maksim b1d3a1a
Merge branch 'apache:main' into main
kazantsev-maksim e2de8c0
Merge branch 'apache:main' into main
kazantsev-maksim e6fd376
Merge branch 'apache:main' into main
kazantsev-maksim 11528e3
Merge branch 'apache:main' into main
kazantsev-maksim e17397f
Merge branch 'apache:main' into main
kazantsev-maksim b79e747
Merge branch 'apache:main' into main
kazantsev-maksim 3988b0f
Merge branch 'apache:main' into main
kazantsev-maksim f705c43
Merge branch 'apache:main' into main
kazantsev-maksim 741747d
Merge branch 'apache:main' into main
kazantsev-maksim 9495593
Merge branch 'apache:main' into main
kazantsev-maksim 0ac77df
Merge branch 'apache:main' into main
kazantsev-maksim 1346dc4
Merge branch 'apache:main' into main
kazantsev-maksim b2e0ffd
Merge branch 'apache:main' into main
kazantsev-maksim 74e92e8
work
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance
[P2] Could you add a matched microbenchmark for the newly dispatched arrays-of-maps path before enabling it by default? This marker changes existing queries from Spark projection fallback to Spark-generated evaluation inside the JVM bridge. That path still evaluates
ArraysZiprow by row and additionally imports the input and materializes the nested Arrow output. Avoiding the surrounding projection fallback can pay for those costs, but the two correctness queries do not establish when it does.Please compare dispatch enabled with the existing dispatcher-disabled fallback on identical nonconstant column inputs, including a map-only projection and the mixed native projection, small and multi-batch inputs, and small versus larger maps/arrays. Verify the same results and include warm steady-state timings with the batch size and data shape. I am not asserting a measured slowdown. The missing comparison is the evidence needed to assess the default-path performance tradeoff.