Repository navigation
Fix Windows file deletion races in TailerTest - #928
Merged
garydgregory merged 1 commit intoNov 9, 2026
Merged
Conversation
garydgregory
force-pushed
the
fix-tailer-test-windows-races
branch
from
November 9, 2026 19:05
df92a4d to
a2607b1
Compare
Retry deletion while the tailer temporarily holds the file open. After requesting shutdown, clean up validated files on Windows before JUnit removes the temporary directory. Preserve validation failures when cleanup also fails, and document the synchronization assumptions.
garydgregory
force-pushed
the
fix-tailer-test-windows-races
branch
from
November 9, 2026 19:39
a2607b1 to
feb37bb
Compare
garydgregory
added a commit
that referenced
this pull request
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows file deletion races in TailerTest.