perf: pre-compile regex in RegexMatch for better performance#1721
Open
Herrtian wants to merge 1 commit intoapache:masterfrom
Open
perf: pre-compile regex in RegexMatch for better performance#1721Herrtian wants to merge 1 commit intoapache:masterfrom
Herrtian wants to merge 1 commit intoapache:masterfrom
Conversation
RegexMatch() called regexp.MatchString() which recompiles the pattern on every invocation. Use the existing mustCompileOrGet() cache instead. Ref apache#1690
Herrtian
force-pushed
the
perf/precompile-regex-in-regexmatch
branch
from
4f91d7c to
f4fa290
Compare
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref #1690
RegexMatch()usedregexp.MatchString()which recompiles the regex pattern on every single invocation. This is a performance bottleneck sinceRegexMatchis called byKeyMatch2,KeyMatch3,KeyMatch5, and can be used directly in policy matchers.Change
Replaced
regexp.MatchString()with the existingmustCompileOrGet()cache that is already used throughout the codebase for other KeyMatch functions. The compiled regex is cached in a thread-safe map and reused on subsequent calls.Test plan
go build ./...passesgo test ./...— all tests passgo test ./util/...— all util tests pass including regex match tests🤖 Generated with Claude Code