BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service#1200
Open
LiJie20190102 wants to merge 1 commit intoapache:masterfrom
Open
BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service#1200LiJie20190102 wants to merge 1 commit intoapache:masterfrom
LiJie20190102 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Why ERROR and WARN messages are not shown at all after the patch is applied? Those messages seem not to be related to multiple slf4j bindings. |
Contributor
Author
Member
|
I meant the log messages related to HiveConf and FileUtils should be emitted even after fixing duplicate slf4j bindings. |
Contributor
Author
Member
|
Hmm. I can not reproduce the issue by just installing both Hive and HBase. Is the issue already fixed in master (and maybe branch-3.2) by upgrading HBase? There is no slf4j-reload4j-1.7.33.jar in the output of |
iwasakims
reviewed
Oct 22, 2023
| # depends on HBASE-8438 (hbase-0.94.14+, hbase-0.96.1+) for `hbase mapredcp` command | ||
| for x in $($HBASE_BIN mapredcp 2>&2 | tr ':' '\n') ; do | ||
| - if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* ]] ; then | ||
| + if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* || $x == *log* || $x == *slf4j* ]] ; then |
Member
There was a problem hiding this comment.
*log* looks prone to future bug by matching unintentional files. What is the target jar here?
Same to *slf4j*. Are you really sure that all jars matching the pattern should be excluded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…e hive service
Description of PR
Excluding log dependencies corresponding to hbase in the hive service

before:
after:

How was this patch tested?
Launch hive CLI to view startup logs
For code changes: