Repository navigation
benchmarks: ndv benchmarks - #11162
Merged
Merged
Conversation
Contributor
Author
|
@adriangb mentioned some cool ideas about using bloom filters to potential speed this datafusion. this should be a nice way to track progress |
Contributor
|
Thanks for setting this up! I’m not a committed so I can’t officially review but I’m generally in favor of adding more benchmarks :) |
etseidl
approved these changes
Sep 22, 2026
etseidl
left a comment
etseidl
left a comment
Contributor
There was a problem hiding this comment.
Looks good. And this time I ran the benches 😅
Thanks @Rich-T-kid
Jefffrey
added
the
development-process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
set_write_row_group_number_distinct_values was added in #10654 with no benchmarks. This PR adds them so the cost of NDV tracking is visible and regressions are catchable going forward.
What changes are included in this PR?
Adds a
bench_ndvbenchmark group toparquet/benches/arrow_writer.rscovering the data types that NDV tracking supports: Int32 (primitive), Boolean, Utf8, LargeBinary, and FixedSizeBinary(16).Each group writes 10 batches of 65,536 rows through a single ArrowWriter with
set_write_row_group_number_distinct_values(true). Two cardinality shapes are exercised per type: low (100 distinct values, cycling) and high (all unique, random), since hash-set behaviour differs meaningfully between the two.Are these changes tested?
n/a
Are there any user-facing changes?
n/a
cargo bench --bench arrow_writer --features arrow/test_utils -- "ndv/"