Skip to content

remove confusing S3 configuration fields in test repositories #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leslieduan wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −16
Open

remove confusing S3 configuration fields in test repositories #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f84d5
remove confusing S3 configuration fields in test repositories
leslieduan Sep 9, 2026
5201fca
Merge branch 'main' of https://github.com/aodn/data-access-service in…
leslieduan Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions tests/repositories/test_sites_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ class _GroupedRepo(ParquetRepository):
"""Mooring-shaped: groups its series by NOMINAL_DEPTH."""

table = "test_mooring"
bucket = "test-bucket"
snapshot_bucket = "test-snapshot"
dataset = "s3://test-bucket/test_mooring.parquet"
snapshot_dataset = "s3://test-snapshot/test_mooring.parquet"
# Required class attrs (see ParquetRepository.__init_subclass__), but these
# tests never call load()/read_snapshot()/write_snapshot(), so there's no
# real S3 location to point at — empty strings satisfy the check without
# implying a connection to real data.
bucket = ""
snapshot_bucket = ""
dataset = ""
snapshot_dataset = ""
time_column = "TIME"
site_column = "site_code"
latitude_column = "LATITUDE"
Expand All @@ -36,10 +40,11 @@ class _UngroupedRepo(ParquetRepository):
"""Wave-buoy-shaped: no group dimension."""

table = "test_buoy"
bucket = "test-bucket"
snapshot_bucket = "test-snapshot"
dataset = "s3://test-bucket/test_buoy.parquet"
snapshot_dataset = "s3://test-snapshot/test_buoy.parquet"
# Unused location fields — see the comment on _GroupedRepo above.
bucket = ""
snapshot_bucket = ""
dataset = ""
snapshot_dataset = ""
time_column = "TIME"
site_column = "site_name"
latitude_column = "LATITUDE"
Expand All @@ -51,10 +56,11 @@ class _QcRepo(ParquetRepository):
"""Grouped, with both value columns QC-gated."""

table = "test_qc"
bucket = "test-bucket"
snapshot_bucket = "test-snapshot"
dataset = "s3://test-bucket/test_qc.parquet"
snapshot_dataset = "s3://test-snapshot/test_qc.parquet"
# Unused location fields — see the comment on _GroupedRepo above.
bucket = ""
snapshot_bucket = ""
dataset = ""
snapshot_dataset = ""
time_column = "TIME"
site_column = "site_code"
latitude_column = "LATITUDE"
Expand Down Expand Up @@ -255,10 +261,10 @@ def test_qc_columns_length_must_match_value_columns_or_be_empty():

class _MismatchedQcRepo(ParquetRepository):
table = "x"
bucket = "test-bucket"
snapshot_bucket = "test-snapshot"
dataset = "s3://test-bucket/x.parquet"
snapshot_dataset = "s3://test-snapshot/x.parquet"
bucket = ""
snapshot_bucket = ""
dataset = ""
snapshot_dataset = ""
time_column = "TIME"
site_column = "site_code"
latitude_column = "LATITUDE"
Expand Down