fix: 图片降级重试#3352
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a referrerPolicy option to the asyncDrawImage utility, allowing image load retries to bypass certain anti-leech CDNs by using no-referrer. It also correctly reorders the assignment of crossOrigin and referrerPolicy to occur before setting the image src. The review feedback recommends using explicit null/undefined checks (!= null or !== null) instead of truthy checks for crossOrigin and referrerPolicy. This ensures that valid empty string values ("") are not incorrectly ignored as falsy.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Size Change: +71 B (+0.01%) Total Size: 745 kB 📦 View Changed
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-v2.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
修复在跨域条件下的图片获取失败
📝 Description
🖼️ Screenshot