Skip to content

fix(inertia): v3 prop resolution: once metadata, scroll wrapper/reset, partial paths, rescued props (#768–#773) - #798

Merged
antosubash merged 9 commits into
mainfrom
fix/inertia-resolver-768-773
Nov 3, 2026
Merged

antosubash merged 9 commits into
mainfrom
fix/inertia-resolver-768-773

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Makes simple_module_inertia's prop resolver conform to the Inertia v3 protocol and the inertia-laravel 3.x PropsResolver (tracking #780).

Closes #768
Closes #769
Closes #770
Closes #771
Closes #772
Closes #773

What changed

Deliberate differences from Laravel

  • always() props, and children of a resolved value, keep their merge and once labels on a partial reload. The protocol table says merge metadata is sent "when resolved".
  • Anything inside a list item resolves eagerly (no index drift).

Verification

https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2

…, partial paths, rescued props (#768-#773)

- Once props the client already holds stay announced in onceProps (#768);
  partial reloads resolve a requested once prop despite except-once (#769).
- scroll() labels <prop>.data by default (wrapper=None for root) and reports
  X-Inertia-Reset in scrollProps.reset (#770).
- Partial reloads emit merge/once metadata only for selected paths (#771) and
  honour dotted only/except paths inside plain dicts before loaders run (#772).
- defer(..., rescue=True) logs a failing loader, omits it and lists it in
  rescuedProps (#773).
- Plain JSON leaves/containers take a fast path: a 5k-message i18n + 500-row
  render drops from 10.8 ms to 8.6 ms.

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
- matchPropsOn uses the merge path, so scroll match_on announces posts.data.id
- always props and children of a resolved value keep merge/once labels on partial reloads
- list fast path covers non-container leaves; clearer awaitable test case
- docs: once/scroll/rescue/dotted-path semantics in module-authoring and the adapter spec

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
- wrapped list items resolve eagerly (no index drift); dict-nested optional/defer
  announced at dotted paths, noted in CHANGELOG
- spec: rescue/wrapper params, rescuedProps, reset semantics, nested wrappers
- _included docstring for the ancestors flag

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
- optional/defer inside an already-resolved value (list rows, loader results)
  resolve eagerly instead of vanishing on full visits
- scroll over a resolved bare list merges at the prop root (wrapper applies to
  dict pages); restores the pre-existing bare-list expectations

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
- scroll docs: a bare list merges at the root automatically; wrapper=None roots a dict
- drop constant arguments in the full-visit deferred branch

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
- except-once does not skip a once prop inside an already-resolved value (no index drift)
- README scroll() signature order

Claude-Session: https://claude.ai/code/session_01FXHA3ZJ5EgoJN4zXTAhBR2
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05a87fb
Status: ✅  Deploy successful!
Preview URL: https://1d55a13e.simple-module-python.pages.dev
Branch Preview URL: https://fix-inertia-resolver-768-773.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-03T18:13:58.104400Z 09a72c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit 666fc9d into main Nov 3, 2026
16 checks passed
@antosubash
antosubash deleted the fix/inertia-resolver-768-773 branch November 3, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment