Repository navigation
fix(cli): PEP 440 release ordering for package-update; honour uv workspace excludes (#766, #767) - #794
Merged
Conversation
…space excludes (#766, #767) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Skip unparseable version spellings instead of aborting package-update. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Treat invalid specifier bounds as skips; keep a ~= floor below a pre-release latest. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
PEP 440 wildcard matching via packaging (epochs, dev/post); drop the dead numeric version_key. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
6d6ca15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e372fc90.simple-module-python.pages.dev |
| Branch Preview URL: | https://feat-b46-cli-version-order.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…order # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smpy package-updatenow orders releases by PEP 440 (packaging.version.Version) instead of a numeric-only key:--include-pre, rc2 beats rc1 and a final release beats its RCs;==X rcNpin moves to the finalX;packagingis now a CLI runtime dependency, so the hand-written comparators now delegate to it (_compare, wildcard matching,</<=/!=checks).workspace_member_dirsapplies[tool.uv.workspace].exclude, reusinguv_workspace.is_workspace_member. An excluded project is left byte-for-byte unchanged; covered for an exact path and a glob.Closes #766
Closes #767
Review
/ship pipeline: optimize (nothing safe to remove), then three correctness passes plus a maintainability pass (Sonnet). Fixed along the way:
~=floor bumped past a pre-release;is_valid_version;Deferred: replacing the remaining hand-written helpers in
git_versions.pywithSpecifierSet. It changes behaviour, andversion_tupleis public.Verification
make lint: passes.make test-py: 7250 passed. The one local failure is the known/tmp/.gitsandbox placeholder (test_clean_target_is_not_in_repo); it passes once the placeholder is removed.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4