Skip to content

fix(users): unbounded OAuth token columns; configurable signup_default_role (#1054, #1055) - #1057

Merged
antosubash merged 3 commits into
mainfrom
fix/users-oauth-token-signup-role-1054-1055
Nov 20, 2026
Merged

antosubash merged 3 commits into
mainfrom
fix/users-oauth-token-signup-role-1054-1055

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Verification

  • Live QA against a disposable Postgres DB, with uvicorn and curl:
    • before the migration, the columns are VARCHAR(1024); after upgrade heads, both are TEXT and alembic check is clean;
    • 4000-character tokens are stored;
    • self-signup with labeller gets [labeller];
    • a stored ADMIN is ignored at hydration and the signup gets [user];
    • a stored ghost (no such role) grants [] and logs a warning.
  • Local CI: make lint ✓, make test-js 998 ✓, PYTEST_WORKERS=8 make test-py 9521 passed ✓.
  • /ship: optimize, then 2 review passes (Codex correctness and maintainability; pass 2 clean on both), then live QA with 0 bugs.
  • Report: https://claude.ai/artifact/N6navpufyG3LwTrJRWXGbW

Report links are Claude Artifacts and start private.

Rollback note: downgrading a1054e9c7b62 on Postgres fails if a stored token is longer than 1024 characters.

Closes #1054
Closes #1055

https://claude.ai/code/session_01FXHA3Zj78w6GWaNKoovHq6

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-20T14:59:13.693801Z 4ca6c95 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ca6c95
Status: ✅  Deploy successful!
Preview URL: https://d6c7f742.simple-module-python.pages.dev
Branch Preview URL: https://fix-users-oauth-token-signup.simple-module-python.pages.dev

View logs

@antosubash antosubash added the shipped /ship passed on the head commit label Nov 20, 2026
@antosubash

Copy link
Copy Markdown
Owner Author

/ship passed on 4ca6c95

  • Rounds: 1 (converged)
  • Review passes: 2. Pass 1: correctness clean; maintainability had 4 findings, all fixed. Pass 2: clean on both.
  • QA: live Postgres QA, 0 bugs found
  • CI: PR checks pass
  • Report: https://claude.ai/artifact/N6navpufyG3LwTrJRWXGbW

@antosubash
antosubash merged commit 5822ee9 into main Nov 20, 2026
19 checks passed
@antosubash
antosubash deleted the fix/users-oauth-token-signup-role-1054-1055 branch November 20, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shipped /ship passed on the head commit

Projects

None yet

1 participant