Repository navigation
fix(users): unbounded OAuth token columns; configurable signup_default_role (#1054, #1055) - #1057
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
4ca6c95
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6c7f742.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-users-oauth-token-signup.simple-module-python.pages.dev |
Owner
Author
|
/ship passed on 4ca6c95
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users_oauth_account.access_token/refresh_tokenbecome TEXT. Users migrationa1054e9c7b62widens existing tables, so Microsoft Entra sign-in no longer fails withvalue too long for type character varying(1024)on Postgres. Autogenerate no longer offers to shrink the columns back.signup_default_rolesetting (defaultuser) for local self-signup, likeoauth_signup_default_role. The role is looked up and never created. A blank value or a missing role grants nothing (with a warning), andadminis refused. The admin guard is now shared by both settings.Verification
upgrade heads, both are TEXT andalembic checkis clean;labellergets [labeller];ADMINis ignored at hydration and the signup gets [user];ghost(no such role) grants [] and logs a warning.make lint✓,make test-js998 ✓,PYTEST_WORKERS=8 make test-py9521 passed ✓./ship: optimize, then 2 review passes (Codex correctness and maintainability; pass 2 clean on both), then live QA with 0 bugs.Rollback note: downgrading
a1054e9c7b62on Postgres fails if a stored token is longer than 1024 characters.Closes #1054
Closes #1055
https://claude.ai/code/session_01FXHA3Zj78w6GWaNKoovHq6