feat: Move and improve USD to HTML logic to visualization interface#575
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 498e2c5.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…all] - Add line_color validation (CSS hex color regex) in export_usd_to_html - Fix source type annotation: str | Path | object (was missing object) - Add upper-bound to usd-core: >= 24.0,< 26 - Add usd-core and ansys-tools-usdviewer to [all] extra - Add test_invalid_line_color_raises and test_valid_line_color_passes - Fix integration test to capture and assert return value - Ensure EOF newline in usdviewer.rst Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ests pytest.importorskip finds the mock pxr injected by unit-test sys.modules.setdefault, so add a sentinel check that skips when pxr.Usd.Stage.CreateInMemory is absent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Covers four scenarios: file-path input, in-memory Stage input, wireframe overlay options, and opening the result in a browser. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Required so doc builds can execute the USD-to-HTML export example. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…vious SDD scratch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cross-file test order can shadow this file's pxr mocks because test_usd_interface.py assigns sys.modules['pxr'] = MagicMock() while this file used setdefault. Whichever module loads last wins, and _inject_mesh_lines does 'from pxr import UsdGeom' at call time, so setting _mock_usd_geom.Mesh.return_value became a silent no-op. Switch to plain assignment and add an autouse fixture that reinstalls the mocks and resets _mock_usd_geom before every test in the class. This unblocks test_with_triangle_prim_injects_eighteen_floats, which now passes in both isolated and full-suite runs. Also amend the migration plan to drop 'ruff format --check' from Task 10: the repo's pre-commit only runs the ruff linter, and indent-style=tab would convert every space-indented file to tabs — a policy change out of scope for this migration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
documentation
AlejandroFernandezLuces
marked this pull request as ready for review
July 17, 2026 10:46
RobPasMue
approved these changes
Jul 20, 2026
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Overall logic seems good but a lot of code.. i'm guessing it's all necessary but it's hard to review such a big PR
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Member
|
Documenting how to create a custom template will be needed - apart from that all good! |
RobPasMue
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale behind this migration is mainly because for this conversion we do not need to have the compiled version of OpenUSD. I think it is better to just have the functionality here, since most packages are already consuming this one.