fix: label the task card edit button for screen readers - #465
Open
Mario-Mohar wants to merge 1 commit into
Open
Conversation
The edit button in the card footer had neither aria-label nor title, so its accessible name fell back to the emoji and was announced as "pencil, button". Sighted users got no tooltip either, and the button only fades in on hover. Add aria-label and title, matching the pattern the copy and pin buttons next to the title already use, plus the explicit type="button" those siblings carry. Closes anoopcodehack#450
Contributor
Author
|
Hi @anoopcodehack — friendly nudge in case this one slipped past you.
It is a three-line change to one file, and it closes #450. Happy to rebase or adjust anything you would like changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gives the ✏️ edit button in the task card footer an
aria-labeland atitle.Why
The button had neither, so its accessible name fell back to its own content — the ✏️ emoji — and a screen reader announced it as "pencil, button" instead of describing the action. Sighted users got no tooltip either, and since the button only fades in on hover there was nothing else to go by.
The copy and pin buttons next to the title already follow this pattern, so this just brings the third button in line with its siblings. It also picks up the explicit
type="button"those two carry.Testing
Ran the board locally with several tasks and inspected the rendered button: its accessible name is now "Edit task" rather than the emoji, the tooltip appears on hover, and clicking it still opens the edit modal as before. No console errors.
Closes #450