Fix/directory handling combined #6711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuv1337
force-pushed
the
fix/directory-handling-combined
branch
from
3270ae2 to
77b3b20
Compare
When attaching to a remote server, the TUI wasn't properly passing the working directory context. This fix ensures consistent directory handling by: - Passing --dir argument from attach command through TUI to SDK client - Using sync.data.path.directory for file autocomplete URLs - Using sync.data.path.directory for custom theme discovery - Using sync.data.path.directory for exports and path normalization - Adding normalizePathFromDirectory utility function
Tests for the normalizePathFromDirectory helper function covering: - Converting absolute paths to relative paths - Preserving already-relative paths unchanged - Handling input equal to base directory (returns '.') - Handling empty input (returns '')
shuv1337
force-pushed
the
fix/directory-handling-combined
branch
from
77b3b20 to
f99c175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TUI attach command not properly passing the working directory context to the SDK client.
Changes:
--dirargument from attach command through TUI to SDK viax-opencode-directoryheadersync.data.path.directoryfor file autocomplete, theme discovery, exports, and path normalizationnormalizePathFromDirectoryutility function with testsbefore:
tui-attach-before.mp4
after:
tui-attach-after.mp4