feat(tui): add auto_scroll config to disable session viewport follow#33248
Open
kailauber wants to merge 1 commit into
Open
feat(tui): add auto_scroll config to disable session viewport follow#33248kailauber wants to merge 1 commit into
kailauber wants to merge 1 commit into
Conversation
Setting auto_scroll to false stops the conversation pane from snapping to the bottom when new content arrives. Default stays true, so existing behavior is unchanged.
kailauber
force-pushed
the
fix/tui-scroll-snap-during-history-read
branch
from
ac67f97 to
e66d77b
Compare
Author
|
Reopening to retrigger CI after the upstream ghostty-web tarball 504 (now resolved). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Type of change
What does this PR do?
Adds an
auto_scrollflag totui.json. Defaulttruekeeps current behavior. Setting it tofalsedisables sticky-bottom on the session scrollbox so the viewport stays where the user left it while messages stream in.Useful when reading earlier history during a long response, or for slow local models where the auto-snap is jarring on every token.
Surface area
TuiConfig.InfostickyScrollis now driven by the config instead of a hardcodedtrueauto_scrollis picked up from the legacyopencode.json -> tuiblock and written into the newtui.jsonalongside the existingscroll_speed/scroll_acceleration/diff_stylekeysConfigtype extended withauto_scrollin the legacytuiblockpackages/web/src/content/docs/tui.mdxHow did you verify your code works?
bun turbo typecheck— 23/23 packages greenpackages/tui/test/config.test.tsx— schema acceptsauto_scroll: true|falseand rejects non-booleanspackages/opencode/test/config/tui.test.ts— migration test assertsauto_scroll: falsesurvives theopencode.json -> tui.jsonmigration{ "auto_scroll": false }intui.json: scrolling up during a streaming reply no longer jumps back to the bottomNote on
check-duplicatesThe first CI run failed on
bun installbecause GitHub's tarball endpoint foranomalyco/ghostty-webwas returning 504 during the run. The endpoint has recovered and the local pre-push hook now passes the same install + typecheck path that the workflow runs. Since the duplicate-check workflow only triggers onopenedand notsynchronize, the failed status is sticky on this PR; happy to close and re-open it if that helps.Checklist