feat(app): add delete button for sessions in sidebar#33208
Open
achmalll wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33129
Type of change
What does this PR do?
Adds a delete (trash) icon button next to the existing archive button on each root session row in the project/session sidebar (legacy/prod layout).
Clicking the trash icon opens a confirmation dialog. After confirming, the app calls the existing
client.session.deleteAPI to permanently remove the session. If the deleted session is currently active, the user is redirected to the next session or the new-session view.The implementation intentionally reuses existing patterns (
archiveSession,useDialog,Dialog,IconButton, i18n strings, and thetrashicon) to keep the change small and consistent.How did you verify your code works?
I ran the following locally:
I also manually tested the legacy sidebar: hovered over a session, clicked the trash icon, confirmed the dialog, and verified the session is removed from the list.
Screenshots / recordings
Checklist