fix(agent): skip parseModel when model is "inherit", trim whitespace#33202
Open
yjlc-pc wants to merge 1 commit into
Open
fix(agent): skip parseModel when model is "inherit", trim whitespace#33202yjlc-pc wants to merge 1 commit into
yjlc-pc wants to merge 1 commit into
Conversation
f90ebf9 to
93bd1c1
Compare
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Can you approve the workflows,dear developers? |
Signed-off-by: yjlc-pc <yjlc.18979607766@outlook.com>
93bd1c1 to
ceef9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17890, #31141, #5623, #8896, #23908
Type of change
What does this PR do?
Custom .md subagents with model: inherit (the default when no model is specified in frontmatter) crash with ProviderModelNotFoundError. The string "inherit" is passed directly to Provider.parseModel(), which splits on / and produces {providerID: "inherit", modelID: ""}. Since no provider named "inherit" exists, Provider.getModel() throws ProviderModelNotFoundError on every subagent invocation.
Additionally, some YAML frontmatter parsers (e.g. gray-matter) may leave trailing
on model strings, which also causes Provider.parseModel() to fail on otherwise valid model IDs.
Fix:
How did you verify your code works?
Screenshots / recordings
N/A - backend logic fix.
Checklist