Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The Material color spec maps on-surface-variant in the dark scheme to neutral-variant tone 80. angular#29655 changed it to tone 90 based on a Theme Builder screenshot whose label was wrong (material-theme-builder#301), which makes on-surface-variant identical in tone to on-surface.
cinja
force-pushed
the
fix/dark-on-surface-variant
branch
from
November 13, 2026 13:57
93b859a to
2eeed4e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps
on-surface-variantin the dark scheme back toneutral-varianttone 80, matching material-color-utilities, the material-web tokens and the output of thetheme-colorschematic.#29655 changed this value to tone 90 based on a Theme Builder label that did not match the rendered color (material-foundation/material-theme-builder#301). #29902 already reverted another change from that PR, which was based on a mislabeled swatch as well.
Fixes #34134
🤖 Generated with Claude Code