Open
Conversation
…into release/2.0.0
…proguard files | Clean up build files
…FolderResult.Starting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up rewriting all the still relevant changes with #142 as base branch. Somehow all the commits you did to the branch are now included in the PR too and I couldn't quite figure out how to fix that, as I'm not sooo well versed with git yet.
Once again, the list of the changes I made:
Internal
com.vanniktech:gradle-maven-publish-pluginto 0.28.0,org.jetbrains.dokka:dokka-gradle-pluginto 1.9.20, gradle to 8.8ExampleUnitTests,buildFeatures { viewBinding = true }from the storage build file,deps.coroutines.corekotlinsource sets and the sample java files into ajavasource set, respectivelyFileWrapperimplementations value classes, which enables the compiler to optimize away lots of the overhead introduced by the wrapper class referenceSingleFileResult.ValidatingandSingleFileResult.Preparing@FloatRange(0.0, 100.0)annotation toInProgress.progressfields which clarifies its value rangeBreaking
implementations instead ofapis, except fordeps.documentfileSingleFileResult.CountingFiles,SingleFileResult.Starting,SingleFolderResult.Starting, which weren't ever emittedSingleFileResult.Completedto the following for type clarityZipDecompressionResult.Completed.zipFile: DecompressedZipFileMediaFile.AccessCallbackinterface, and instead introduced a MediaFilevar onWriteAccessDenied: OnWriteAccessDenied? = nullconstructor parameter withtypealias OnWriteAccessDenied = (mediaFile: MediaFile, sender: IntentSender) -> Unit