Really fix AD4630-20/AD4632-20 data capture#3250
Merged
nunojsa merged 1 commit intoanalogdevicesinc:mainfrom Apr 14, 2026
Merged
Really fix AD4630-20/AD4632-20 data capture#3250nunojsa merged 1 commit intoanalogdevicesinc:mainfrom
nunojsa merged 1 commit intoanalogdevicesinc:mainfrom
Conversation
Using a larger data width made SPI transfers run 4 additional bits which caused the capture data to be shifted by 4 bits. Use the correct data width for 20-bit precision ADCs, making SPI transfers run 20 SCLK pulses per transfer which in turn will make the controller gather only the expected data bits to the sample buffer. Fixes: 299dc60 ("iio: adc: ad4630: Add support for AD4630-20 and AD4632-20") Signed-off-by: Marcelo Schmitt <[email protected]>
machschmitt
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
mhennerich,
nunojsa,
rbolboac and
stefpopa
as code owners
nunojsa
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
It happens that #3241 missed updating the data width to 20-bit.
This time, I got confirmation from an application engineer that data capture runs as expected. Finally fix the data capture on main xD
PR Type
PR Checklist