make seculartriple an installable AMUSE package#25
make seculartriple an installable AMUSE package#25silviatoonen merged 3 commits intoamusecode:mainfrom
Conversation
|
@LourensVeen could you have a look at this? |
LourensVeen
left a comment
LourensVeen
left a comment
There was a problem hiding this comment.
This looks good overall, but there's a few bits of cleanup that would be nice to do, and I worry that the autom4te stuff could cause problems because it contains settings specific to your system that could be picked up by others.
Unfortunately, this got merged already without a review, but maybe you can make a new PR with these fixes?
| @@ -0,0 +1 @@ | |||
| c c++ fortran java python cmake install download mpi openmp cuda opencl x11 opengl blas lapack gsl gmp mpfr fftw hdf5 netcdf4 | |||
There was a problem hiding this comment.
I bet it doesn't really have all of these dependencies. Anyway the file can be deleted, because it would only be used by the AMUSE ./setup script, which we don't have because this is an out-of-tree binding.
| @@ -0,0 +1,92 @@ | |||
| # This file was generated by Autom4te 2.73. | |||
There was a problem hiding this comment.
As the path implies, this is a cached file that should not be checked into git. Please remove the whole autom4te.cache directory.
| @@ -0,0 +1,90 @@ | |||
| # Compilers | |||
There was a problem hiding this comment.
This file is generated from config.mk.in, and should not be checked in. Please remove and add to .gitignore.
| # PERL = @PERL@ | ||
|
|
||
|
|
||
| # AMUSE framework libraries |
There was a problem hiding this comment.
It's better to remove all this stuff, rather that commenting it out, to avoid confusion.
| AS_IF([test $RANLIB = ":"], [AC_MSG_ERROR([ranlib command not found.])]) | ||
|
|
||
|
|
||
| # Find tools to download and unpack with |
3 participants
This intends to fix #24 (first part) by making Seculartriple installable under the new build system.
Needs testing.