Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Added GraphQLOperation annotation support.#17

Open
jeremygiberson wants to merge 2 commits into
americanexpress:masterfrom
privoro:16-operation-annotation
Open

Added GraphQLOperation annotation support.#17
jeremygiberson wants to merge 2 commits into
americanexpress:masterfrom
privoro:16-operation-annotation

Conversation

@jeremygiberson

Copy link
Copy Markdown

References #16

  • set maven default build source/target to 1.7. (should be set to min compile level at least, 1.7 felt safe)
  • add annotation, tweaked argument annotation to add variable reference
  • refactor requestentity wrapping top level property w/ operation
  • added test scenario for working with operations.
  • todo - more tests to exercise each operation parameter

- set maven default build source/target to 1.7. (should be set to min compile level at least, 1.7 felt safe)
- add annotation, tweaked argument annotation to add variable reference
- refactor requestentity wrapping top level property w/ operation
- added test scenario for working with operations.
- todo - more tests to exercise each operation parameter
@CLAassistant

CLAassistant commented Jul 9, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeremygiberson

Copy link
Copy Markdown
Author

Btw, do you have recommendation on how to run style linting locally so I don't have to push & wait for travis ci to check fixes?

@chemdrew

chemdrew commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Hey @jeremygiberson, thanks for opening the PR! I really like the idea of adding the operation, this makes it a lot clearer on what the root node of the property tree we are building is instead of checking for null fields. To run the tests with checkstyle + coverage checks I recommend mvn clean verify

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants