chore(deps-dev): bump electron from 42.3.3 to 43.0.0 in the root-npm-dependencies group across 1 directory#1803
Merged
itomek merged 3 commits intoJul 6, 2026
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/root-npm-dependencies-69237af177
branch
from
cae0ce7 to
293e063
Compare
Bumps the root-npm-dependencies group with 1 update in the / directory: [electron](https://github.com/electron/electron). Updates `electron` from 42.3.3 to 43.0.0 - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v42.3.3...v43.0.0) --- updated-dependencies: - dependency-name: electron dependency-version: 42.4.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: root-npm-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/root-npm-dependencies-69237af177
branch
from
293e063 to
37cb237
Compare
The root-npm-dependencies group bump touched every workspace member's package.json but not their independently-committed package-lock.json files, so npm ci in the per-app CI jobs (test-apps-build, dependency consistency checks) failed with a lockfile/manifest mismatch. Regenerate src/gaia/apps/example/webui/package-lock.json and src/gaia/apps/jira/webui/package-lock.json against electron ^43.0.0 so all four electron declarations (root, framework, example, jira) agree.
2 tasks
Collaborator
|
Verified locally on macOS arm64: with all four electron declarations at ^43.0.0, the packaged example app launches and renders on Electron 43.0.0 and the electron test suites pass. Pushed b5e43e7 to regenerate the two per-app lockfiles (example, jira) this group bump left at 42.3.3 — that mismatch is what was failing the build-apps / Test Electron Runtime jobs ( This PR now carries the complete, self-consistent upgrade; #1802 and #1804 are superseded by it and closed.
🔍 Verification details
Tested via: root |
This was referenced Jul 6, 2026
pull Bot
pushed a commit
to bhardwajRahul/gaia
that referenced
this pull request
Jul 6, 2026
…md#1927) "Test Electron Framework" has been red on main and every PR since 2026-06-22: amd#1750 renamed the Agent UI window title to "GAIA Agent UI", but `test_electron_chat_app.js` still expects `<title>GAIA</title>`. This aligns the assertion with the actual title — the same suite already asserts `displayName: 'GAIA Agent UI'`, so the rename was clearly intentional. Unblocks the check on Dependabot PRs amd#1803, amd#1805, amd#1861 among others. ## Test plan - [x] `npx jest test_electron_chat_app.js` locally: 196/196 pass with the fix (previously 195/196) - [ ] "Test Electron Framework" green on this PR Co-authored-by: Tomasz Iniewicz <tomasz@iniewicz.com>
itomek
deleted the
dependabot/npm_and_yarn/root-npm-dependencies-69237af177
branch
Contributor
|
🟡 The main Agent UI ( 🔍 Technical details
"electron": "^42.2.0",Its |
pull Bot
pushed a commit
to bhardwajRahul/gaia
that referenced
this pull request
Jul 7, 2026
) Fixes amd#1933. The Agent UI Vitest job could fail on unrelated PRs: `SettingsPage.test.tsx > is disabled and reflects the env value when locked` flaked on CI (Dependabot [amd#1802](amd#1802) run [28763820070](https://github.com/amd/gaia/actions/runs/28763820070) and [amd#1803](amd#1803)) while passing on identical code elsewhere, eroding trust in a red check. The tests waited for the toggle to *exist*, but it renders from first paint (unchecked, disabled until settings load), so assertions and clicks raced the async `getSettings()` flush — clicks on the still-disabled toggle silently no-op. Five of the seven tests carried the race; CI load determined whether it fired. After: the tests wait for the *settled* state (toggle enabled, or the lock note for the locked case), and the API mocks resolve one macrotask later — like real HTTP — so the race stays permanently exposed instead of masked. (No env-var or cross-file state leakage was involved; the "env value" in the test name is the `GAIA_DYNAMIC_TOOLS` lock note rendered by the UI.) ## Proof Race reproduced deterministically on unfixed code by giving the mocks a realistic 30 ms response latency (kept in this PR as the regression guard) — including the exact assertion that failed in CI: ``` ❯ src/components/__tests__/SettingsPage.test.tsx (7 tests | 5 failed) × renders the loaded value (off by default) × toggles when the visible row/label is clicked, not just the hidden input × is disabled and reflects the env value when locked × guards against a double-click while a save is in flight (single PUT) × reverts and surfaces an error when the save fails (no silent fallback) ``` With the fix, stable under shuffle and repetition (run in `src/gaia/apps/webui`): ``` $ for seed in 1 42 777 20260706 999983; do npx vitest run --sequence.shuffle --sequence.seed=$seed; done seed=1 Tests 109 passed (109) seed=42 Tests 109 passed (109) seed=777 Tests 109 passed (109) seed=20260706 Tests 109 passed (109) seed=999983 Tests 109 passed (109) ``` 15 consecutive runs of the file: 0 failures. `npx tsc --noEmit` clean. Also fixed: `getSystemStatus` was mocked as `null`, throwing a `TypeError` inside the component in every test's stderr; it now returns a valid `SystemStatus`. ## Test plan - [ ] `cd src/gaia/apps/webui && npx vitest run` — 109/109 pass - [ ] `npx vitest run --sequence.shuffle` (any seed) — 109/109 pass - [ ] Vitest CI job green on this PR Co-authored-by: Tomasz Iniewicz <tomasz@iniewicz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the root-npm-dependencies group with 1 update in the / directory: electron.
Updates
electronfrom 42.3.3 to 43.0.0Release notes
Sourced from electron's releases.
... (truncated)
Commits
5147ac2test: fix lost-event race in custom-protocol-panel devtools fixture (#52194)765def3ci: improve lint job code reuse (#52180)07f9757fix: remove 1px frame background color from the top of frameless windows on L...2e29d7fbuild: register Electron.app with LaunchServices before macOS tests (#52186)3a77e4afix: inherit iframe sandbox flags in windows opened on the OpenURL navigation...3846728chore: bump chromium to 150.0.7871.46 (43-x-y) (#52123)c0d5334ci: calculate rerun apply patches date from first run attempt (#52075)4a2ff4bbuild: only run gn-typescript-definitions for default toolchain (#52165)c3d3305chore: cherry-pick 1 changes from chromium (#52168)dad4f73fix: use the registering session for ProtocolResponse.url requests (#52131)