refactor(hnsw): use turbo for distance calculation - #735
Open
richyreachy wants to merge 24 commits into
Open
richyreachy wants to merge 24 commits into
richyreachy wants to merge 24 commits into
Conversation
iaojnh
reviewed
Sep 21, 2026
| case QuantizerType::kInt8: | ||
| return "Int8Quantizer"; | ||
| case QuantizerType::kInt4: | ||
| return "Int4Quantizer"; |
Collaborator
There was a problem hiding this comment.
将 INT4 内积 HNSW 合并到 INT4 L2 Flat 时,MixedStreamerReducer 根据量化器名称和记录尺寸判定可直接复制,但两种度量的 INT4 尾部字段含义不同。切换到 Turbo 后,这条路径会跳过必要的重新编码。
实测 36 维向量 [1, 0, …] 合并后与自身的距离为 −10.1733,直接构建及旧实现对照均约为 0。建议合并兼容性判断增加度量检查,不一致时解码并重新编码。
Collaborator
Author
There was a problem hiding this comment.
已修复。兼容性判断增加了 metric 一致性检查,跨 metric 合并时会先用源量化器解码,再用目标量化器重新编码;同 metric 的直接复制路径保留。
…into refactor/hnsw_on_turbo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts migrating HNSW distance calculation from the legacy
IndexMetriccallback mechanism to the Turbo quantizer interface.The goal is to make quantizers own vector encoding, query preprocessing, distance dispatch, and dequantization, allowing the old converter/reformer and direct metric invocation paths to be removed as the remaining quantizers are migrated.
What changed
Current migration scope
The new quantizer-owned distance path is currently enabled for dense FP32 HNSW indexes using:
Other configurations temporarily continue to use the legacy distance path until their Turbo quantizers are integrated.
Motivation
Previously, HNSW distance calculation was spread across converters, reformers,
IndexMetric, and streamer-level function callbacks. This made encoding and distance dispatch separate concerns and required HNSW to understand implementation-specific details.Moving distance calculation behind the Turbo quantizer interface provides one owner for:
This simplifies HNSW and establishes a common path for removing the old distance invocation mechanism.
Compatibility