Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
richyreachy
previously approved these changes
Apr 8, 2026
zhourrr
requested changes
Apr 8, 2026
src/core/utility/buffer_storage.cc
Outdated
| int init(const ailego::Params ¶ms) override { | ||
| params.get(BUFFER_STORAGE_MEMORY_SIZE, &buffer_size_); | ||
| LOG_INFO("buffer size: %lu", buffer_size_); | ||
| // LOG_INFO("buffer size: %lu", buffer_size_); |
Collaborator
There was a problem hiding this comment.
Better to use LOG_DEBUG here, together with other useful debug info, such as file name, some offsets, etc
| namespace zvec { | ||
| namespace ailego { | ||
|
|
||
| class LPMap; |
Collaborator
There was a problem hiding this comment.
What does LPMap mean? Use a meaningful name or write a comment to be readable
Collaborator
Author
There was a problem hiding this comment.
rename it to "VectorPageTable"
zhourrr
reviewed
Apr 8, 2026
zhourrr
reviewed
Apr 9, 2026
src/ailego/buffer/lru_cache.cc
Outdated
| if (!ok) { | ||
| return false; | ||
| } | ||
| if (item.lp_map == nullptr) { |
Collaborator
Author
There was a problem hiding this comment.
rename it to VectorPageTable
| @@ -18,6 +18,7 @@ | |||
| #include <unordered_map> | |||
| #include <zvec/ailego/internal/platform.h> | |||
| #include "concurrentqueue.h" | |||
| #include "lru_cache.h" | |||
|
|
|||
| #if defined(_MSC_VER) | |||
| @@ -0,0 +1,151 @@ | |||
| #pragma once | |||
|
|
|||
| #include <sys/stat.h> | |||
zhourrr
reviewed
Apr 9, 2026
src/ailego/buffer/lru_cache.cc
Outdated
| @@ -0,0 +1,158 @@ | |||
| #include <zvec/ailego/buffer/parquet_buffer_pool.h> | |||
…aojnh/zvec into feat/merge-vector-arrow-buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.