fix: remove redundant Python-side vector index type validation in create_index#297
Merged
zhourrr merged 3 commits intoalibaba:mainfrom Apr 14, 2026
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
songqing
changed the title
zhourrr
force-pushed
the
fix/bug1-create-index-isinstance
branch
from
7aa5f08 to
0820ab8
Compare
zhourrr
approved these changes
Apr 14, 2026
zhourrr
requested changes
Apr 14, 2026
songqing
force-pushed
the
fix/bug1-create-index-isinstance
branch
from
0820ab8 to
f57a80c
Compare
songqing
changed the title
zhourrr
force-pushed
the
fix/bug1-create-index-isinstance
branch
from
8d3fb0e to
80d7a38
Compare
zhourrr
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original check used
inoperator to validate whether an index paraminstance belongs to vector index types, which is always False since it
compares an instance against classes. Rather than fixing it with
isinstance, remove the entire Python-side validation and delegate typechecking to the C++ core, which already handles it properly and avoids
the risk of the Python type list falling out of sync.