Skip to content

refactor(agent): centralize resolved configuration - #211

Merged
JHWang-1997 merged 5 commits into
mainfrom
refactor/resolved-agent-config
Aug 20, 2026
Merged

refactor(agent): centralize resolved configuration#211
JHWang-1997 merged 5 commits into
mainfrom
refactor/resolved-agent-config

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • build one role-aware ResolvedAgentConfig after YAML, CLI, and credential loading
  • resolve legacy slashed CLI model references once without mutating the loaded eval config, then pass the resolved value directly to adapters
  • reuse the same resolver for agent_judge while inheriting the runner engine lifecycle, and report the resolved runner identity

Compatibility

  • preserves legacy --model provider/name, opaque slashed model IDs, YAML provider/name pairs, provider environment precedence, local-login delegation, and Qoder auto semantics
  • lets an explicit CLI model bypass superseded YAML provider/name environment references while continuing to resolve active base URL and model params
  • does not add --provider, protocol-aware nested credentials, capability validation, or a public judge-engine schema

Testing

  • make verify
  • make test
  • make test-action
  • make e2e (all non-live paths passed; the local live Qoder CLI 0.2.0 run returned a successful response but did not expose token usage, so its existing non-zero token assertion failed)

Part of #196

@JHWang-1997 JHWang-1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one immutability issue in the new resolved configuration. Kwargs and ModelParams are cloned, but the custom-engine configuration is still shared with the loaded eval config.

Comment thread internal/credential/agent_init.go
@zpzjzj
zpzjzj requested a review from JHWang-1997 August 19, 2026 07:00

@JHWang-1997 JHWang-1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JHWang-1997
JHWang-1997 added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 8566175 Aug 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants