refactor(agent): centralize resolved configuration - #211
Merged
Conversation
JHWang-1997
requested changes
Aug 19, 2026
JHWang-1997
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes for one immutability issue in the new resolved configuration. Kwargs and ModelParams are cloned, but the custom-engine configuration is still shared with the loaded eval config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolvedAgentConfigafter YAML, CLI, and credential loadingagent_judgewhile inheriting the runner engine lifecycle, and report the resolved runner identityCompatibility
--model provider/name, opaque slashed model IDs, YAML provider/name pairs, provider environment precedence, local-login delegation, and Qoderautosemantics--provider, protocol-aware nested credentials, capability validation, or a public judge-engine schemaTesting
make verifymake testmake test-actionmake e2e(all non-live paths passed; the local live Qoder CLI 0.2.0 run returned a successful response but did not expose token usage, so its existing non-zero token assertion failed)Part of #196