Skip to content

test(agent): characterize configuration compatibility - #205

Merged
JHWang-1997 merged 2 commits into
mainfrom
refactor/agent-config-characterization
Aug 18, 2026
Merged

test(agent): characterize configuration compatibility#205
JHWang-1997 merged 2 commits into
mainfrom
refactor/agent-config-characterization

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • document the current engine, protocol, provider, model, auth, and local-login semantics as a compatibility contract
  • add characterization tests for the public GitHub Action input-to-CLI/environment translation
  • keep historical --model provider/name, opaque slashed model IDs, and empty-engine delegation documented
  • run the Action adapter tests in GitHub CI with an explicitly provisioned Python version

Scope

This is phase 1 of #196. It intentionally does not change runtime configuration behavior or add --provider; it establishes the compatibility boundary for the later resolver and adapter refactors.

Verification

  • make verify
  • make test
  • make test-action

Part of #196

Copy link
Copy Markdown
Collaborator

The tests cover argv construction and engine_env() separately, but not the final composition of engine_env(), engine_model_env(), and provider_env() in main(). A future refactor could break Agent Judge model selection or Codex custom-provider routing while all tests still pass. Please add a characterization test for the complete argv/environment assembly path.

@zpzjzj

zpzjzj commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed in 0e8752f. Added test_main_composes_codex_argv_and_environment, which exercises the complete main() orchestration path with external operations mocked, then asserts the final argv, Agent Judge OPENAI_MODEL, engine auth/base URL, and Codex custom-provider environment. Verified with make verify, make test, and make test-action.

@JHWang-1997 JHWang-1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JHWang-1997
JHWang-1997 added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 9e20c29 Aug 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants