Skip to content

ci: use trusted Windows runner for manual E2E - #186

Merged
JHWang-1997 merged 3 commits into
mainfrom
ci/windows-self-hosted-runner
Aug 18, 2026
Merged

ci: use trusted Windows runner for manual E2E#186
JHWang-1997 merged 3 commits into
mainfrom
ci/windows-self-hosted-runner

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • route maintainer-dispatched Windows E2E and live-model checks to the trusted self-hosted Windows runner
  • keep merge-group Windows code on ephemeral GitHub-hosted runners so persistent state cannot cross into later secret-bearing jobs
  • verify Git for Windows, Git Bash, and symlink capability before running tests
  • document runner labels, PATH, Developer Mode, persistence, and trust boundaries in English and Chinese
  • use stock Windows PowerShell so PowerShell 7 is not an undocumented host prerequisite

Validation

  • make verify
  • make test
  • actionlint .github/workflows/extended-ci.yml .github/workflows/model-e2e.yml
  • Extended CI run 31768265668: Windows E2E passed on IZTW1IE30KF87BZ with 73 pass, 33 expected skip, 0 fail; the overall workflow failed only because an unrelated Linux Docker runner could not access /var/run/docker.sock
  • Model E2E run 31768419858: Windows Claude token-usage test and artifact upload passed; readback reported 20,693 input and 25 output tokens

Security boundary

merge_group continues to select windows-2025. Only maintainer-authorized workflow_dispatch runs select [self-hosted, Windows, X64, trusted].

@zpzjzj
zpzjzj requested a review from hittyt as a code owner August 14, 2026 04:01
@zpzjzj
zpzjzj requested a review from JHWang-1997 August 18, 2026 02:08

@JHWang-1997 JHWang-1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JHWang-1997
JHWang-1997 added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit ad1302e Aug 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants