You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the proposal and implementation. I understand that this command provides domain-aware comparison, such as primary-case handling, case transition classification, and CI exit codes.
However, if the scope is only comparing two local result.json files, the value of adding a dedicated built-in command is not yet very clear to me. The current pass-rate, status, token, and duration comparison can already be implemented fairly cheaply with jq or a small script, while this PR introduces a relatively large amount of code and a new CLI contract that we will need to maintain.
I think the feature would be more compelling if it formed part of a complete baseline workflow—for example:
locating or selecting the baseline result automatically;
comparing against the latest release or a named baseline;
handling result schema compatibility across versions;
providing richer regression evidence beyond case status;
offering a reusable CI integration that individual repositories would otherwise need to maintain themselves.
Could you clarify the concrete user workflow this is intended to unlock, and what advantage the built-in command provides over a documented jq/script example? If the intention is only raw offline file comparison, I’m not yet convinced that the maintenance cost is justified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill-up compare <old-result.json> <new-result.json>for text and JSON result diffs.Test Plan
GOCACHE=/private/tmp/skill-up-go-build-cache GOTOOLCHAIN=go1.26.4 make verifyGOCACHE=/private/tmp/skill-up-go-build-cache GOTOOLCHAIN=go1.26.4 make testCloses #175