feat(judge): add output_matches rule - #173
Merged
Merged
Conversation
zpzjzj
reviewed
Aug 11, 2026
zpzjzj
reviewed
Aug 11, 2026
zpzjzj
left a comment
Collaborator
There was a problem hiding this comment.
Code review summary
- 🟠 Major: 1
- 🔴 Blocker: 0
The implementation scope and the normal all / any / not paths look consistent with #165. One reproducible edge-case bug remains in output_matches.not: an empty Go regex is mistaken for the no-match sentinel. I left the details inline.
Overall: conditionally ready after the Major finding is fixed.
Manual source review and focused reproduction @ 13edd02ea043d0379d2cbc4e2d35d7be9b18536a; 1 finding accepted, 0 downgraded, 0 rejected. The configured local automated reviewer was unavailable.
googs1025
force-pushed
the
feat/rule-based-output-matches
branch
from
August 11, 2026 03:01
763524b to
2153234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
output_matchessupport to the deterministicrule_basedjudge so eval authors can assert final output with Go regular expressions without changingoutput_containsliteralmatching semantics.
Related issues
Closes #165
Changes
output_matchesrule schema withall,any, andnotgroups.output_matchesagainst the final message inRuleBasedJudge.Test plan
make testpassesmake verifypasses (fmt + vet + lint)Notes for reviewers
output_containsremains literal substring matching. Tool-set aliases and output section checks from the original issue are intentionally deferred.