Skip to content

fix(page-controller): dispatch input before change on select option - #686

Open
9426Haruka wants to merge 1 commit into
alibaba:mainfrom
9426Haruka:fix/select-option-input-event
Open

9426Haruka wants to merge 1 commit into
alibaba:mainfrom
9426Haruka:fix/select-option-input-event

Conversation

@9426Haruka

Copy link
Copy Markdown

What

Native <select> interactions dispatch input before change. This updates selectOptionElement to follow that order so React-controlled and other event-driven forms receive both events.

Type

  • Breaking change
  • Bug fix
  • Feature / Improvement
  • Refactor / Chores
  • Documentation / Website / Demo / Testing

Testing

  • npm run ci passes
  • Tested with a happy-dom unit test
  • Types/doc added

Added a page-controller test asserting that the selected value updates and that input is dispatched before change.

Requirements / 要求

  • I have read and follow the Code of Conduct and Contributing Guide . / 我已阅读并遵守行为准则。
  • This PR is NOT generated by a bot or AI agent acting autonomously. I have authored or meaningfully reviewed every change. / 此 PR 不是由 bot 或 AI 自主生成的,我已亲自编写或充分审查了每一处变更。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant