fix(build): make cleanup script cross-platform - #683
Open
9426Haruka wants to merge 1 commit into
Open
9426Haruka wants to merge 1 commit into
9426Haruka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the Unix-only cleanup command (
m -rf ... && rm -rf ...) in the root package.json with a small Node script that reads the workspace list and removes dist / .output directories using
ode:fs. No new dependencies.
This keeps
pm run cleanup portable across Windows, macOS, and Linux.
Type
Testing
pm run ci\ passes
Verified locally on Windows:
pm run cleanup, and both directories were removed.
px prettier --check scripts/cleanup.js package.json\ passes.
px eslint scripts/cleanup.js\ passes.
Requirements / 要求