fix(pages): use startTransition to eliminate black screen flash during page navigation - #789
Closed
wu21-web wants to merge 7 commits into
Closed
fix(pages): use startTransition to eliminate black screen flash during page navigation#789wu21-web wants to merge 7 commits into
wu21-web wants to merge 7 commits into
Conversation
Contributor
|
🔍 OpenCodeReview found 4 issue(s) in this PR.
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wu21-web
marked this pull request as ready for review
August 8, 2026 06:51
Collaborator
|
Hi @wu21-web, thank you for taking the time to work on this! Your approach with However, we've decided to go with #792 for this fix, as it takes a similar core approach but also includes:
We'll be closing this PR in favor of #792. That said, if after merging #792 we find that transitions still feel long enough to need visual feedback, we may revisit the progress bar idea — feel free to open a follow-up PR for that if you're interested. Thanks again for contributing! |
Contributor
Author
|
Thank you, agreed. AI has a better talent in dealing with css and typescripts. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
startTransition keeps old page visible; Suspense fallback navigation only triggers on initial load
and also added a progess bar
and avaliable for deskotp + mobile devices
Type of Change
How Has This Been Tested?
make testpasses locallynpm run lintnpm testgives errors that are not specific to my edits.Checklist
go fmt,go vet)Related Issues
closes #788