fix(updater): discard stale version hints - #720
Open
Linxiushen wants to merge 2 commits into
Open
Conversation
Contributor
|
🔍 OpenCodeReview found 3 issue(s) in this PR.
|
Collaborator
|
@Linxiushen Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. |
Linxiushen
force-pushed
the
fix/current-version-update-hint
branch
from
August 5, 2026 10:02
4b719f1 to
227e050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The npm wrapper now validates a persisted update hint against the installed npm package version before displaying it. This avoids launching the native binary in the CLI startup path. Hints for the current or an older version, malformed hints, and hints that cannot be compared safely are removed immediately; a valid newer hint is still shown.
Version parsing and comparison live in a shared module used by both the background updater and wrapper. Build metadata is accepted and ignored for precedence, and malformed inputs fail closed.
Closes #697.
Type of Change
How Has This Been Tested?
node scripts/version.test.jsgo test ./...go vet ./...The focused tests cover current, older, and newer versions; malformed hint and installed versions; build metadata; parsing; and stable-versus-prerelease cases.
Checklist
go fmt,go vet)AI Assistance
I used AI assistance to trace the stale hint lifecycle, extract the shared version helpers, and draft tests. I reviewed the final diff and ran the checks listed above.
Related Issues
Closes #697