Conversation
This reverts commit 14c93de.
liulx20
added a commit
that referenced
this pull request
Sep 9, 2026
## What do these changes do? A clean parallel extension build can compile `neug_parquet_carquet_impl` before protobuf generation finishes. Its input/output stream headers include `neug/utils/result.h`, which requires the generated `neug/generated/proto/plan/error.pb.h`, causing a missing-header compilation failure. Add an explicit dependency on `neug_proto` so generation completes before the Carquet adapters compile. This changes only one line in the Parquet CMake configuration. ### Validation A focused clean CMake build using the adapter target definition and the actual adapter sources reproduced the missing-header failure without the dependency. With the dependency, it generated `error.pb.h` and compiled both adapter sources successfully with `-j4`. Full extension CI remains to be verified. ## Related issue number Observed in [extension CI](https://github.com/alibaba/neug/actions/runs/34305275798/job/102322246010?pr=1039). The same missing dependency exists on main; this fix is submitted separately from #1039.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Operators currently exchange materialized
Contextvalues, which prevents downstream consumers from pulling individual batches through a pipeline. This change makes operator inputs and outputsStream<ContextChunk>and connects nested pipelines through the same pull interface.read(..., Context&)methods, their full-collection helpers, unusedReadLocalState, and the obsoletebatch_readoption. Reader tests pull suppliers directly, including interleaved independent Parquet suppliers.This changes the operator and reader registration interfaces. It does not make every underlying algorithm incremental: global operators still buffer, CSV retains its row-count prepass, and JSON retains its DOM parser. Existing non-reader extension callback boundaries still use Context.
Validation
Cannot shrink read buffer if buffered data remains; the prebuilt dependency lacks the repository's GH-48311 Arrow patch. This case has not been verified with patched Arrow.Related issue number
Related to #1002; no issue is automatically closed.