feat(cosh): add kitty csi-u keys support with sequence timeout management#552
Open
kongld-mq wants to merge 1 commit into
Open
feat(cosh): add kitty csi-u keys support with sequence timeout management#552kongld-mq wants to merge 1 commit into
kongld-mq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Kitty CSI-u keyboard protocol support with sequence timeout management to KeypressContext, enabling proper handling of printable CSI-u keys, unsupported sequences, and plain text recovery after interrupted CSI sequences.
The Kitty keyboard protocol uses CSI-u sequences (ESC[;u) for enhanced keyboard reporting. Previously, printable CSI-u keys were not handled correctly, which could cause issues with text input in CLI applications.
Key changes:
Related Issue
closes #
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpasspackage-lock.json/Cargo.lock)Testing
Verification:
Additional Notes
Implementation ported from qwen-code commits: