Skip to content

Fix out-of-bounds read in copy_poly_in_matrix for monomials #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohabsafey merged 1 commit into from
Oct 2, 2026
Merged

Fix out-of-bounds read in copy_poly_in_matrix for monomials #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/msolve/hilbert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,13 @@ static inline void copy_poly_in_matrix(sp_matfglm_t* matrix,
fprintf(ERRSTREAM, "\n");
#endif

/* pos is the length of the polynomial; if pos < 2, it is a monomial:
* it has no tail, hence the corresponding row stays zero
* (dense_mat is zero-initialized) */
if(pos < 2){
return;
}

long N = nrows * (matrix->ncols) - (start + 1);

if((end-start) == matrix->ncols + 1){
Expand Down Expand Up @@ -801,6 +808,13 @@ copy_poly_in_matrixcol(sp_matfglmcol_t* matrix, long nrows,
}
fprintf(ERRSTREAM, "\n");
#endif
/* pos is the length of the polynomial; if pos < 2, it is a monomial:
* it has no tail, hence the corresponding row stays zero
* (dense_mat is zero-initialized) */
if(pos < 2){
return;
}

long N = nrows * (matrix->ncols) - (start + 1);

if((end-start) == matrix->ncols + 1){
Expand Down
Loading