Merging develop into Master #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d older methods...
* Add GetCreatedTimestamp and GetLastExecutionTimestamp to Build interface * Feature: Add GetRecentBuildJobs() API to UIEnvironment Add new API method to retrieve recent validated build jobs for touchscreen UI display. Changes: 1. **IDL Definition** (ACT/LibMCEnv.xml): - Added BuildIterator class following BuildExecutionIterator pattern - Added GetRecentBuildJobs(maxCount) method to UIEnvironment 2. **BuildIterator Implementation**: - New class CBuildIterator (libmcenv_builditerator.hpp/cpp) - Implements GetCurrentBuild() to return IBuild instances - Follows standard AMCF iterator pattern 3. **UIEnvironment Implementation** (libmcenv_uienvironment.cpp): - GetRecentBuildJobs() queries validated build jobs via DataModel - Returns BuildIterator with most recent jobs (newest first) - Limited by maxCount parameter 4. **CBuild Factory Methods** (libmcenv_build.cpp/hpp): - Added makeFrom() and makeSharedFrom() static methods - Enables BuildIterator to wrap existing build job instances This API enables plugins to access build job data for UI display without direct DataModel access, maintaining proper abstraction. --- InterfacesCode: Regenerate interface files from ACT for GetRecentBuildJobs API Regenerated C++ interface bindings and headers using ACT (Automatic Component Toolkit) after adding GetRecentBuildJobs() method to LibMCEnv.xml. Generated/Updated files: - Framework/HeadersDev/CppDynamic/libmcenv_dynamic.hpp - Framework/HeadersDev/CppDynamic/libmcenv_dynamic.h - Framework/HeadersDev/CppDynamic/libmcenv_types.hpp - Framework/InterfacesCore/libmcenv_abi.hpp - Framework/InterfacesCore/libmcenv_interfaces.hpp - Framework/InterfacesCore/libmcenv_interfacewrapper.cpp - Framework/InterfacesCore/libmcenv_types.hpp - ACT/act.linux (binary timestamp update) These files are auto-generated by running: ./act.linux LibMCEnv.xml
…ystem (#62) E.g. to exclude drivers from build: ./build_clean_linux64.sh -DINCLUDE_DRIVERS=OFF
Removed redundant null checks for pValueBuffer and m_PixelData, these checks stops the two-call pattern of the GetPixels().
…f child (#64) Bug: AddObjectValue() and AddArrayValue() were returning a pointer to the parent object instead of the newly created child value, causing JSON structure corruption. Fix: 1. Call AddMember() to add the member to the parent 2. Use &(*m_pInstance)[sName.c_str()] to get pointer to the newly added child value in the parent's member map Impact: This bug affected any endpoint using AddArrayValue() or nested AddObjectValue(), such as my /api/ext/builds/list which uses arrays. The error "Referenced JSON value is not array" occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.