Refactor: Extract Auth Form Logic to useAuthForm - #281
albertoivo wants to merge 1 commit into
Conversation
- Created `useAuthForm.ts` to manage form state and logic for `LoginPage.tsx` and `RegisterPage.tsx` - Renamed poorly named variable `anyLoading` to `isFormDisabled` - Reduced duplicate code across auth pages and improved SRP - Passed all verification checks (tsc, lint, test, build) Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit dfcfd83): https://pyexplorer-cd32d--pr281-refactor-auth-form-6-6surojhg.web.app (expires Thu, 24 Sep 2026 00:44:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61 |
|
The main branch is already in production. I can't merge anything there unless I'm 109% sure that there is no errors. |
1 participant
Extracted form state (
isLoading,isGoogleLoading,localError,successMessage,email,password, etc.) and reusable form operations likehandleGoogleSignInandclearAllErrorsinto a genericuseAuthFormhook. Replaced the generic and poorly namedanyLoadingboolean withisFormDisabled. This eliminates code duplication across theLoginPageandRegisterPagecomponents and strengthens the type safety and code clarity within the project.PR created automatically by Jules for task 6813760720702885228 started by @albertoivo