chore: upgrade alauda doom #89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| "name": "doomslayer", | ||
| "packageManager": "[email protected]", | ||
| "devDependencies": { | ||
| "@alauda/doom": "^1.17.1", | ||
| "@tailwindcss/postcss": "^4.1.12", | ||
| "@ts-stack/markdown": "^1.5.0", | ||
| "autoprefixer": "^10.4.21", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,194 @@ | ||
| @import "tailwindcss"; | ||
|
|
||
| .editLink { | ||
| color: var(--rp-c-brand); | ||
| text-decoration: none; | ||
| font-size: 15px; | ||
| font-weight: 500; | ||
| transition: all 0.2s ease-in-out; | ||
| padding-left: 12px; | ||
| } | ||
|
|
||
| .editLink:hover { | ||
| color: var(--rp-c-brand-dark); | ||
| } | ||
|
|
||
| .paginationItem { | ||
| font-weight: 500; | ||
| cursor: pointer; | ||
| font-size: var(--text-sm); | ||
| line-height: var(--tw-leading, var(--text-sm--line-height)); | ||
|
|
||
| --tw-font-weight: var(--font-weight-medium) /* 500 */; | ||
| font-weight: var(--font-weight-medium) /* 500 */; | ||
|
|
||
| margin-inline: calc(var(--spacing) * 1.5) /* 0.375rem = 6px */; | ||
| padding-inline: calc(var(--spacing) * 3) /* 0.75rem = 12px */; | ||
| padding-block: calc(var(--spacing) * 2) /* 0.5rem = 8px */; | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
Comment on lines
+16
to
+30
Contributor
There was a problem hiding this comment. Remove duplicate The Apply this diff to remove the duplicate: .paginationItem {
- font-weight: 500;
cursor: pointer;
font-size: var(--text-sm);
line-height: var(--tw-leading, var(--text-sm--line-height));
--tw-font-weight: var(--font-weight-medium) /* 500 */;
font-weight: var(--font-weight-medium) /* 500 */;🧰 Tools🪛 Biome (2.1.2)[error] 23-23: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally. font-weight is already defined here. Remove or rename the duplicate property to ensure consistent styling. (lint/suspicious/noDuplicateProperties) 🤖 Prompt for AI Agents |
||
|
|
||
| .paginationItem:hover { | ||
| background-color: var(--rp-c-bg-soft); | ||
| cursor: pointer; | ||
| color: var(--rp-c-brand-dark); | ||
| border-radius: var(--rp-radius); | ||
| } | ||
|
|
||
| .paginationItem.active { | ||
| background-color: var(--rp-c-bg-soft); | ||
| cursor: pointer; | ||
| color: var(--rp-c-brand-dark); | ||
| border-radius: var(--rp-radius); | ||
| } | ||
|
|
||
| .paginationItem.disabled { | ||
| cursor: not-allowed; | ||
| color: var(--rp-c-gray); | ||
| background-color: transparent; | ||
| border: none; | ||
| } | ||
|
|
||
| .rp-font-bold { | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| .card { | ||
| display: block; | ||
| border: 1px solid var(--rp-c-divider-light); | ||
| border-radius: var(--rp-radius); | ||
| background-color: var(--rp-c-bg); | ||
| padding: 1rem; | ||
| } | ||
|
|
||
| .card__title { | ||
| font-size: 1.125rem; | ||
| font-weight: 600; | ||
| margin-bottom: 0.75rem; | ||
| color: var(--rp-c-text-1); | ||
| } | ||
|
|
||
| .card__content { | ||
| color: var(--rp-c-text-2); | ||
| } | ||
|
|
||
| .link-card { | ||
| display: block; | ||
| border-bottom: 1px solid var(--rp-c-divider-light); | ||
| background-color: var(--rp-c-bg); | ||
| padding: 1.25rem; | ||
| text-decoration: none; | ||
| transition-property: color, background-color, border-color; | ||
| transition-timing-function: cubic-bezier(0.4, 0, 0.2, 1); | ||
| transition-duration: 150ms; | ||
| } | ||
|
|
||
| .link-card:hover { | ||
| background-color: var(--rp-c-bg-soft); | ||
| } | ||
|
|
||
| .link-card__title { | ||
| font-size: 1.125rem; | ||
| font-weight: 600; | ||
| margin-bottom: 0.5rem; | ||
| color: var(--rp-c-text-1); | ||
| line-height: 1.75rem; | ||
| } | ||
|
|
||
| .link-card__description { | ||
| color: var(--rp-c-text-2); | ||
| font-size: 0.875rem; | ||
| line-height: 1.5rem; | ||
| } | ||
|
|
||
| .post-meta { | ||
| display: flex; | ||
| font-size: 0.875rem; | ||
| color: var(--rp-c-text-3); | ||
| line-height: 1.5rem; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| @media (min-width: 640px) { | ||
| .post-meta { | ||
| line-height: 2rem; | ||
| } | ||
| } | ||
|
|
||
| .breadcrumb { | ||
| margin-bottom: 2.5rem; | ||
| } | ||
|
|
||
| .home-footer { | ||
| margin-top: 3rem; | ||
| padding-top: 2rem; | ||
| padding-bottom: 2rem; | ||
| padding-left: 1.5rem; | ||
| padding-right: 1.5rem; | ||
| width: 100%; | ||
| border-top: 1px solid var(--rp-c-divider-light); | ||
| } | ||
|
|
||
| @media (min-width: 640px) { | ||
| .home-footer { | ||
| padding: 2rem; | ||
| } | ||
| } | ||
|
|
||
| .home-footer__content { | ||
| margin: auto; | ||
| width: 100%; | ||
| text-align: center; | ||
| font-weight: 500; | ||
| font-size: 0.875rem; | ||
| color: var(--rp-c-text-2); | ||
| } | ||
|
|
||
| .rp-doc-layout__menu { | ||
| display: none; | ||
| position: fixed; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| z-index: 100; | ||
| background-color: var(--rp-c-bg); | ||
| border-bottom: 1px solid var(--rp-c-divider-light); | ||
| padding: 0.75rem 1rem; | ||
| align-items: center; | ||
| gap: 0.5rem; | ||
| } | ||
|
|
||
| @media (max-width: 1280px) { | ||
| .rp-doc-layout__menu { | ||
| display: flex; | ||
| } | ||
| } | ||
|
|
||
| .rp-doc-layout__menu-button { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 2rem; | ||
| height: 2rem; | ||
| padding: 0; | ||
| border: none; | ||
| background: transparent; | ||
| color: var(--rp-c-text-1); | ||
| cursor: pointer; | ||
| border-radius: var(--rp-radius); | ||
| transition: background-color 0.2s; | ||
| } | ||
|
|
||
| .rp-doc-layout__menu-button:hover { | ||
| background-color: var(--rp-c-bg-soft); | ||
| } | ||
|
|
||
| .rp-doc-layout__menu-button:active { | ||
| background-color: var(--rp-c-bg-mute); | ||
| } | ||
|
|
||
| .rp-doc-layout__menu-button svg { | ||
| width: 100%; | ||
| height: 100%; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| import React from "react"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| export interface CardProps { | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| title?: string; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| content?: React.ReactNode; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| style?: React.CSSProperties; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| className?: string; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| children?: React.ReactNode; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| export const Card: React.FC<CardProps> = ({ | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| title, | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| content, | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| style, | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| className = "", | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| children, | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| }) => { | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| <div className={`card ${className}`} style={style}> | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| {title && <div className="card__title">{title}</div>} | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| {content && <div className="card__content">{content}</div>} | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| {children && <div className="card__content">{children}</div>} | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+19
to
+23
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Clarify the intended usage of Both Consider one of the following approaches:
Option 1 (recommended): Mutually exclusive usage export const Card: React.FC<CardProps> = ({
title,
content,
style,
className = "",
children,
}) => {
return (
<div className={`card ${className}`} style={style}>
{title && <div className="card__title">{title}</div>}
- {content && <div className="card__content">{content}</div>}
- {children && <div className="card__content">{children}</div>}
+ {(content || children) && (
+ <div className="card__content">{content || children}</div>
+ )}
</div>
);
};Option 2: Single container for both - {content && <div className="card__content">{content}</div>}
- {children && <div className="card__content">{children}</div>}
+ {(content || children) && (
+ <div className="card__content">
+ {content}
+ {children}
+ </div>
+ )}📝 Committable suggestion
Suggested change
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { forwardRef, useCallback } from "react"; | ||
|
|
||
| export interface CheckboxProps { | ||
| label: string; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { useThemeState } from "@rspress/core/theme-original"; | ||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Find package.json to check RSPress version
find . -name "package.json" -type f | head -5 | xargs head -30
# Search for theme-original usage in codebase
echo ""
echo "=== Searching for theme-original usage ==="
rg "theme-original" --type ts --type tsx -B 2 -A 2
# Search for useThemeState usage
echo ""
echo "=== Searching for useThemeState usage ==="
rg "useThemeState" --type ts --type tsx -B 2 -A 2
# Check if the import file mentioned exists
echo ""
echo "=== Checking the specific file ==="
cat -n "theme/components/Empty/index.tsx" 2>/dev/null || echo "File not found"Repository: alauda/knowledge Length of output: 4692 🏁 Script executed: #!/bin/bash
# Check yarn.lock or package.json for @rspress/core version
echo "=== Checking for @rspress/core in package files ==="
rg "@rspress/core" . --type yaml --type toml --type json -A 2 | head -50
# Check if node_modules exists and search for theme-original
echo ""
echo "=== Searching node_modules for @rspress/core ==="
if [ -d "node_modules/@rspress/core" ]; then
ls -la node_modules/@rspress/core/ | head -20
echo ""
echo "=== Package.json exports from @rspress/core ==="
if [ -f "node_modules/@rspress/core/package.json" ]; then
cat node_modules/@rspress/core/package.json | grep -A 50 '"exports"'
fi
else
echo "node_modules/@rspress/core not found"
# Check what's in @alauda/doom dependencies
echo ""
echo "=== Checking @alauda/doom dependencies ==="
if [ -d "node_modules/@alauda/doom" ]; then
cat node_modules/@alauda/doom/package.json | head -50
fi
fi
# Search for theme-original more broadly
echo ""
echo "=== Searching for any theme-original reference ==="
find node_modules -name "*theme*original*" -o -name "*theme-original*" 2>/dev/null | head -10Repository: alauda/knowledge Length of output: 294 🏁 Script executed: #!/bin/bash
# Check for yarn.lock or package-lock.json
echo "=== Looking for lock files ==="
ls -la | grep -E "lock|yarn"
echo ""
echo "=== Checking yarn.lock for @rspress/core ==="
if [ -f "yarn.lock" ]; then
grep -A 5 "@rspress/core" yarn.lock | head -50
fi
echo ""
echo "=== Checking @alauda/doom package.json for its dependencies ==="
# Check if there's a node_modules/@alauda/doom
if [ -d "node_modules/@alauda/doom" ]; then
cat node_modules/@alauda/doom/package.json 2>/dev/null | jq '.dependencies, .devDependencies, .peerDependencies' | head -100
else
echo "node_modules not available. Checking root package.json for all deps"
cat package.json | jq '.' | head -100
fi
echo ""
echo "=== Checking if there are any RSPress references in codebase ==="
rg "rspress" -i . --type js --type ts --type tsx --type json -B 1 -A 1 | head -50Repository: alauda/knowledge Length of output: 2529 🏁 Script executed: #!/bin/bash
# Check yarn cache or search for @rspress/[email protected] documentation
echo "=== Checking RSPress 2.0.0-rc.2 exports ==="
# Let's look at what the yarn.lock entry says about @rspress/core
echo "Getting full @rspress/core entry from yarn.lock:"
grep -A 30 '"@rspress/core@npm:2.0.0-rc.2":' yarn.lock
# Check if there's any reference to theme-original in the entire yarn.lock
echo ""
echo "=== Searching yarn.lock for 'theme-original' ==="
grep -i "theme-original" yarn.lock
# Check for 'useThemeState' anywhere
echo ""
echo "=== Searching yarn.lock for 'useThemeState' ==="
grep -i "useThemeState" yarn.lockRepository: alauda/knowledge Length of output: 1301 🏁 Script executed: #!/bin/bash
# Let's search for any theme-related imports or exports in RSPress docs/examples
echo "=== Checking if there are other theme imports in project ==="
rg "from ['\"]@rspress" . -A 1 | head -30
# Look at the @alauda/doom version to understand the context better
echo ""
echo "=== Checking @alauda/doom version in yarn.lock ==="
grep -A 10 "@alauda/doom@npm:.*1.17" yarn.lockRepository: alauda/knowledge Length of output: 2349 🏁 Script executed: #!/bin/bash
# Let's verify what exports actually exist in @rspress/core by checking the actual RSPress source
echo "=== Checking if @rspress/core really exports theme-original ==="
# Search for any reference to "theme-original" in the entire project
echo "Files using @rspress/core/theme-original:"
rg "@rspress/core/theme-original" . --type ts --type tsx | wc -l
echo ""
echo "All imports of this path:"
rg "@rspress/core/theme-original" . --type ts --type tsxRepository: alauda/knowledge Length of output: 267 🏁 Script executed: #!/bin/bash
# Check without file type filtering
echo "=== Finding all theme-original references ==="
grep -r "theme-original" . --include="*.ts" --include="*.tsx" 2>/dev/null
echo ""
echo "=== Check if there's a theme-original entry point or custom export ==="
# Check the theme directory structure
find theme -type f -name "*.ts" -o -name "*.tsx" 2>/dev/null | head -20
echo ""
echo "=== Check theme/index.tsx to see what's exported ==="
cat theme/index.tsxRepository: alauda/knowledge Length of output: 1769 🏁 Script executed: #!/bin/bash
# Check if @alauda/doom provides theme-original export
echo "=== Checking @alauda/doom's yarn.lock entry more thoroughly ==="
grep -B 5 -A 50 '"@alauda/doom@npm:1.17.1":' yarn.lock | head -100
echo ""
echo "=== Look for any @rspress references in @alauda/doom dependencies ==="
grep -A 50 '"@alauda/doom@npm:1.17.1":' yarn.lock | grep -i "rspress"Repository: alauda/knowledge Length of output: 194 🏁 Script executed: #!/bin/bash
# Let's search the yarn.lock for @alauda/doom differently
echo "=== Searching for @alauda/doom in yarn.lock ==="
grep "@alauda/doom" yarn.lock | head -20
echo ""
echo "=== Get the full entry for @alauda/doom ==="
awk '/"@alauda\/doom@npm:1\.17\.1":/,/^"[^@]/' yarn.lock | head -100
echo ""
echo "=== Search entire yarn.lock for rspress in dependencies ==="
grep -B 10 "rspress" yarn.lock | grep -E "^\"|rspress"Repository: alauda/knowledge Length of output: 3102 🏁 Script executed: #!/bin/bash
# Check if there's a TypeScript path alias or other configuration mapping theme-original
echo "=== Checking tsconfig.json for path aliases ==="
cat tsconfig.json 2>/dev/null | grep -A 20 "paths"
echo ""
echo "=== Checking rspress.config.ts for any alias configuration ==="
find . -name "rspress.config.ts" -o -name "rspress.config.js" | xargs cat 2>/dev/null
echo ""
echo "=== Check if theme-original might be re-exported from theme/index.tsx ==="
# We already know theme/index.tsx exports from theme-original, but let's confirm what it should be
cat theme/index.tsxRepository: alauda/knowledge Length of output: 707 🏁 Script executed: #!/bin/bash
# Final verification - check what actually exists in @rspress/core exports
echo "=== Checking @rspress/[email protected] package structure from yarn.lock ==="
awk '/"@rspress\/core@npm:2\.0\.0-rc\.2":/,/^"/' yarn.lock | grep -E "exports|bin|main|types" | head -20
echo ""
echo "=== Summary of theme-original usage in codebase ==="
echo "Files importing from @rspress/core/theme-original:"
grep -r "@rspress/core/theme-original" . --include="*.ts" --include="*.tsx" 2>/dev/null | wc -l
echo ""
echo "Functions imported from this path:"
grep -r "from ['\"]@rspress/core/theme-original['\"]" . --include="*.ts" --include="*.tsx" -A 0 2>/dev/null | sed 's/.*from.*//' | sort -uRepository: alauda/knowledge Length of output: 280 🏁 Script executed: #!/bin/bash
# Let's extract the exact imports from each file to understand what's being used
echo "=== Detailed import analysis ==="
grep -B 1 "from ['\"]@rspress/core/theme-original['\"]" . -r --include="*.ts" --include="*.tsx" 2>/dev/null
echo ""
echo "=== Check what components are in standard @rspress/core/theme ==="
# Look at how other @rspress/core/runtime imports work in the project for reference
grep -r "from ['\"]@rspress/core" . --include="*.ts" --include="*.tsx" 2>/dev/null | grep -o "from ['\"]@rspress/core[^'\"]*['\"]" | sort -uRepository: alauda/knowledge Length of output: 1199 Replace non-existent In RSPress v2.0, the package migration is
Change from 🤖 Prompt for AI Agents |
||
| import React from "react"; | ||
|
|
||
| interface EmptyStateProps { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
@alauda/doom npm package breaking changes 1.12.7 to 1.17.1💡 Result:
I can't find an authoritative changelog for @alauda/doom covering 1.12.7 → 1.17.1 with the searches I ran. Could you confirm the package name and that those exact versions exist (or want me to search npm, GitHub repo, and the package's CHANGELOG.md for breaking changes)? If yes I will run a deeper search and report the breaking changes with sources.
🌐 Web query:
@alauda/doom changelog release notes version history💡 Result:
You can find @alauda/doom's changelog and release history here:
If you want, I can fetch the CHANGELOG.md contents (or list recent release notes) and paste the latest entries here.
🌐 Web query:
@alauda/doom package documentation migration guide💡 Result:
Short answer — use the official Doom docs (doom.js.org) migration docs and the package README. Key references and quick steps:
References
Quick migration checklist
If you want, I can:
Sources
Verify migration steps completed for @alauda/doom upgrade.
The upgrade from
^1.12.7to^1.17.1includes breaking changes requiring configuration and setup updates:doom.config.{yaml,yml,js,ts}withdefineConfigexportConfirm that all migration steps from the Doom documentation have been completed.
🤖 Prompt for AI Agents