fix(author): require whole numeric values for factual grounding - #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Author grounding previously accepted a numeric substring as evidence: a source containing
2020,20.5, or20%could support a claimed metric of20. Citation completion and factual validation now share whole numeric-value matching, preserving decimal parts, percentage markers, magnitude suffixes, NFKC normalization, and case normalization. Exact years within date ranges remain supported.Closes #300. This is a deterministic factual-safety correction for the v0.9.0 milestone; it does not resolve or explain the live pilot failures. #75 remains unvalidated and #250 remains blocked. The roadmap records that boundary and splits the affected observation history into readable paragraphs. No CLI, UI, or public contract changes require additional documentation.
Validation
pnpm install --frozen-lockfile,pnpm format, andVITEST_MAX_WORKERS=2 pnpm validateon Node 24.5.0 / pnpm 10.18.3.