fix(async-job): preserve async and stream failure types#994
Open
devin-ai-integration[bot] wants to merge 6 commits into
Open
fix(async-job): preserve async and stream failure types#994devin-ai-integration[bot] wants to merge 6 commits into
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
Replace hardcoded system_error in AsyncJobOrchestrator's aggregated failure with the highest-precedence FailureType among wrapped non-breaking exceptions (config_error > transient_error > system_error). The user-facing message is chosen per FailureType to stay deterministic; underlying failure-type counts and exception reprs are moved into internal_message. Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1776776408-async-job-failure-type-propagation#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1776776408-async-job-failure-type-propagationPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailureType.config_error>transient_error>system_error) and include a deterministic failure-type breakdown in the internal message.FailureTypewhenConcurrentReadProcessor.is_done()raises the final concurrent read failure, instead of always wrapping failed streams asconfig_error.README.mdis a symlink into Airbyte's shared connector docs but whose Docker build context omits that shared target.Review & Testing Checklist for Human
failure_type=transient_error.config_error>transient_error>system_error) is the intended behavior for mixed stream/async failures.config_errorcases.source-hardcoded-recordsanddestination-motherduck; both failed before the image-build fix with entrypoint exit 127.Notes
Local validation performed:
poetry run pytest unit_tests/sources/declarative/async_job/test_job_orchestrator.py unit_tests/sources/declarative/async_job/test_job.py unit_tests/sources/streams/concurrent/test_concurrent_read_processor.py -qpoetry run pytest unit_tests/sources/streams/concurrent/test_concurrent_read_processor.py -qpoetry run pytest -q 'unit_tests/sources/declarative/incremental/test_concurrent_perpartitioncursor.py::test_incremental_parent_state_no_incremental_dependency[test_incremental_parent_state-manifest0-mock_requests0-expected_records0-initial_state0-expected_state0-2]'poetry run ruff check .poetry run ruff format --check .poetry run mypy --config-file mypy.ini airbyte_cdkpoetry run mypy --config-file mypy.ini airbyte_cdk/sources/declarative/async_job/job.py airbyte_cdk/sources/declarative/async_job/job_orchestrator.py airbyte_cdk/utils/docker.pypoetry run mypy --config-file mypy.ini airbyte_cdk/exception_handler.py airbyte_cdk/sources/concurrent_source/concurrent_read_processor.pysource-hardcoded-recordsanddestination-motherduckusing the patched CDK image builder.Full
poetry run mypy --config-file mypy.ini airbyte_cdkinitially failed locally becausetypes-pytzwas missing from the Poetry environment; rerunning with--install-types --non-interactiveinstalled the stub package and the full mypy check passed.Link to Devin session: https://app.devin.ai/sessions/fb20772ef207406d8c0fa12699a5fd2f
Requested by: Daryna Ishchenko (@darynaishchenko)