fix: offload blocking Keycloak introspect to thread pool - #694
Open
suhr25 wants to merge 1 commit into
Open
Conversation
Run python-keycloak's synchronous introspect() via run_in_executor so it no longer freezes the asyncio event loop on every authenticated request. Move access log DB write to a BackgroundTask so it runs after the response is sent instead of blocking the event loop inline. Signed-off-by: suhr25 <suhridmarwah07@gmail.com>
Author
|
Hi @geetu040, |
Author
Author
|
Hi @geetu040, |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a performance issue where blocking I/O was executed inside async code, causing the event loop to stall under load.
Problem
src/authentication.py,_get_user()calledkeycloak_openid.introspect(token), which uses synchronousrequests, blocking the asyncio event loop.src/middleware/access_log.py, a synchronous DBsess.commit()ran inside async middleware, blocking request handling.Fix
Verification
introspect()works correctly with executor