Skip to content

fix: revert set flex_start_max_run_duration_minutes in test runs #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olivermeyer merged 1 commit into from
Jan 20, 2026
Merged

fix: revert set flex_start_max_run_duration_minutes in test runs #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/aignostics/platform/_sdk_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ class GPUConfig(BaseModel):
le=60 * 60,
description="Maximum run duration in minutes when using FLEX_START provisioning mode (1-3600). "
"Required when provisioning_mode is FLEX_START, must be None otherwise.",
exclude_if=lambda v: v is None, # Exclude from serialization if None
)

@model_validator(mode="after")
Expand Down
33 changes: 2 additions & 31 deletions tests/aignostics/platform/sdk_metadata_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@
import pytest
from pydantic import ValidationError

from aignostics.platform import DEFAULT_GPU_PROVISIONING_MODE, DEFAULT_GPU_TYPE, DEFAULT_MAX_GPUS_PER_SLIDE
from aignostics.platform._sdk_metadata import (
ITEM_SDK_METADATA_SCHEMA_VERSION,
SDK_METADATA_SCHEMA_VERSION,
VALIDATION_CASE_TAG_PREFIX,
GPUConfig,
GPUType,
ProvisioningMode,
ValidationCase,
build_item_sdk_metadata,
build_run_sdk_metadata,
Expand Down Expand Up @@ -1000,6 +996,8 @@ def test_pipeline_config_defaults() -> None:
"""Test that pipeline configuration uses correct defaults."""
from aignostics.platform import (
DEFAULT_CPU_PROVISIONING_MODE,
DEFAULT_GPU_PROVISIONING_MODE,
DEFAULT_GPU_TYPE,
DEFAULT_MAX_GPUS_PER_SLIDE,
PipelineConfig,
)
Expand Down Expand Up @@ -1257,30 +1255,3 @@ def test_metadata_with_invalid_validation_case_tag() -> None:
with pytest.raises(ValidationError) as exc:
validate_run_sdk_metadata(metadata)
assert "validation_case" in str(exc.value)


class TestGPUConfig:
"""Test cases for GPUConfig model."""

@pytest.mark.unit
@staticmethod
def test_model_dump_should_include_flex_start_max_duration_if_provided() -> None:
"""Test that flex_start_max_run_duration_minutes is included in model dump if provided."""
config = GPUConfig(
gpu_type=GPUType.L4,
provisioning_mode=ProvisioningMode.FLEX_START,
max_gpus_per_slide=DEFAULT_MAX_GPUS_PER_SLIDE,
flex_start_max_run_duration_minutes=1,
)
assert "flex_start_max_run_duration_minutes" in config.model_dump()

@pytest.mark.unit
@staticmethod
def test_model_dump_should_exclude_flex_start_max_duration_if_not_provided() -> None:
"""Test that flex_start_max_run_duration_minutes is excluded in model dump if not provided."""
config = GPUConfig(
gpu_type=GPUType.L4,
provisioning_mode=ProvisioningMode.SPOT,
max_gpus_per_slide=DEFAULT_MAX_GPUS_PER_SLIDE,
)
assert "flex_start_max_run_duration_minutes" not in config.model_dump()
Loading