[codex] Add Opus confirm phase to factory gate#91
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f92edc5b06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # fixes or dismissals. | ||
| audit dismissals-consumed "$(jq -cn --arg g "$GATE_ID" --argjson f "$findings" --argjson d "$valid_dismissals" \ | ||
| '{gate_id:$g,phase:"pre-confirm",findings:$f,dismissals:$d}')" | ||
| mv "$DISMISSALS" "$STATE_DIR/dismissals-used-$(date +%s).json" |
There was a problem hiding this comment.
When Codex findings are fully dismissed but the confirming reviewer returns new findings, this moves .git/factory/dismissals.json aside even though the overall gate is about to refuse. If the user follows the printed preferred path to fix the confirm findings and re-stage, the staged tree changes, the cached confirm result is invalidated, and the next run reruns the primary reviewer without the still-valid primary dismissals, forcing the user to recreate dismissals for unchanged findings despite no commit having succeeded. That contradicts the script's documented single-use-on-success dismissal workflow.
Useful? React with 👍 / 👎.
|
Closing this as stale/superseded rather than landing it. I rechecked the current t3code gate and the Factory² source of truth. This PR is a direct t3code-local port of the Opus confirm phase and includes the now-obsolete per-invocation Per the factory layering rule, gate machinery should come down from Factory² as a versioned upgrade PR rather than landing a stale hand port in the factory instance. No code from this PR was landed. |
|
Superseded by the current Factory² gate template/policy; should be replaced by a fresh Factory² upgrade PR if still wanted. |
Summary
FACTORY_REVIEW_CONFIRM_ARGSfor Claude Opus 4.8 high in the t3code factory configFACTORY_CONFIRM=0as an explicit per-invocation confirm skip, with a distinct gate cache key so a Codex-only run cannot masquerade as a full-panel passBudget note
This increases Claude/Opus usage on commits whose Codex primary phase passes. Adam is at roughly 80% weekly Claude usage, so
FACTORY_CONFIRM=0is available for non-trivial budget pressure or availability issues while still making skipped runs auditable/cache-distinct.Validation
bash -n scripts/factory/precommit-gate.sh scripts/factory/factory.confFACTORY_CONFIRM=0, Codex finding, and Opus confirm findingnode_modules/.bin/vp run typechecknode_modules/.bin/vp check(passes with existing unrelated mobile unused-symbol warnings)scripts/factory/precommit-gate.sh --prepareusing the current HEAD gate (Codex-only, because this commit changes gate files)Linear: ADA-31