Skip to content

[codex] fix desktop update packaging integrity #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamfgr merged 9 commits into from
Jul 8, 2026
Merged

[codex] fix desktop update packaging integrity #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a12b492
fix desktop update packaging integrity
wizzoapp[bot] Jul 6, 2026
eeb5580
codex: fix desktop update smoke packaging (#96)
wizzoapp[bot] Jul 6, 2026
c35aacc
fix: harden desktop package smoke diagnostics
wizzoapp[bot] Jul 7, 2026
5a72afc
fix: harden desktop package staging paths
wizzoapp[bot] Jul 7, 2026
ddfc50c
test: preserve desktop smoke fatal output
wizzoapp[bot] Jul 7, 2026
9ad50ee
test: focus desktop smoke fatal snapshots
wizzoapp[bot] Jul 7, 2026
73331d6
fix desktop update smoke cleanup
wizzoapp[bot] Jul 8, 2026
150f6c0
fix desktop update smoke platform coverage
wizzoapp[bot] Jul 8, 2026
fc26cdd
fix desktop update smoke isolation
wizzoapp[bot] Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ jobs:
--root "$unpackedRoot" `
--max-files 250

- name: Assert launch smoke rejects missing unpacked backend entry
- name: Assert launch smoke reports missing unpacked runtime file
shell: pwsh
run: |
$ErrorActionPreference = "Stop"
Expand All @@ -240,22 +240,22 @@ jobs:
Copy-Item -Recurse -Force (Join-Path $cleanInstallDir "*") $brokenInstallDir

$brokenAppExe = Join-Path $brokenInstallDir (Split-Path -Leaf $cleanAppExe)
$removedBackendEntry = Join-Path $brokenInstallDir "resources/app.asar.unpacked/apps/server/dist/bin.mjs"
if (-not (Test-Path $removedBackendEntry)) {
throw "Negative launch-smoke fixture could not find packaged backend entry to remove: $removedBackendEntry"
$removedRuntimeFile = Join-Path $brokenInstallDir "resources/app.asar.unpacked/apps/server/dist/bin.mjs"
if (-not (Test-Path $removedRuntimeFile)) {
throw "Negative launch-smoke fixture could not find packaged runtime file to remove: $removedRuntimeFile"
}
Remove-Item -Force $removedBackendEntry
Remove-Item -Force $removedRuntimeFile

$output = & node scripts/desktop-launch-smoke.mjs --command "$brokenAppExe" --timeout-ms 45000 --stability-ms 1000 2>&1
$exitCode = $LASTEXITCODE
$outputText = $output | Out-String
$output | ForEach-Object { Write-Host $_ }

if ($exitCode -eq 0) {
throw "Launch smoke passed against a packaged artifact with the backend entry removed; the gate is not trustworthy."
throw "Launch smoke passed against a packaged artifact with a required unpacked runtime file removed; the gate is not trustworthy."
}
if ($outputText -notmatch "(?i)(apps/server/dist/bin\.mjs|missing server entry|backend|timed out)") {
throw "Launch smoke failed against the broken packaged artifact, but did not report the expected missing backend entry."
if ($outputText -notmatch "(?i)(installation is incomplete|apps/server/dist/bin\.mjs)") {
throw "Launch smoke failed against the broken packaged artifact, but did not report the expected incomplete-installation diagnostic."
}

Write-Host "Launch smoke rejected the deliberately broken packaged artifact with exit code $exitCode."
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/reusable-build-release-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ jobs:
--root "$unpackedRoot" `
--max-files 250

- name: Assert launch smoke rejects missing unpacked backend entry
- name: Assert launch smoke reports missing unpacked runtime file
shell: pwsh
run: |
$ErrorActionPreference = "Stop"
Expand All @@ -485,22 +485,22 @@ jobs:
Copy-Item -Recurse -Force (Join-Path $cleanInstallDir "*") $brokenInstallDir

$brokenAppExe = Join-Path $brokenInstallDir (Split-Path -Leaf $cleanAppExe)
$removedBackendEntry = Join-Path $brokenInstallDir "resources/app.asar.unpacked/apps/server/dist/bin.mjs"
if (-not (Test-Path $removedBackendEntry)) {
throw "Negative launch-smoke fixture could not find packaged backend entry to remove: $removedBackendEntry"
$removedRuntimeFile = Join-Path $brokenInstallDir "resources/app.asar.unpacked/apps/server/dist/bin.mjs"
if (-not (Test-Path $removedRuntimeFile)) {
throw "Negative launch-smoke fixture could not find packaged runtime file to remove: $removedRuntimeFile"
}
Remove-Item -Force $removedBackendEntry
Remove-Item -Force $removedRuntimeFile

$output = & node scripts/desktop-launch-smoke.mjs --command "$brokenAppExe" --timeout-ms 45000 --stability-ms 1000 2>&1
$exitCode = $LASTEXITCODE
$outputText = $output | Out-String
$output | ForEach-Object { Write-Host $_ }

if ($exitCode -eq 0) {
throw "Launch smoke passed against a packaged artifact with the backend entry removed; the gate is not trustworthy."
throw "Launch smoke passed against a packaged artifact with a required unpacked runtime file removed; the gate is not trustworthy."
}
if ($outputText -notmatch "(?i)(apps/server/dist/bin\.mjs|missing server entry|backend|timed out)") {
throw "Launch smoke failed against the broken packaged artifact, but did not report the expected missing backend entry."
if ($outputText -notmatch "(?i)(installation is incomplete|apps/server/dist/bin\.mjs)") {
throw "Launch smoke failed against the broken packaged artifact, but did not report the expected incomplete-installation diagnostic."
}

Write-Host "Launch smoke rejected the deliberately broken packaged artifact with exit code $exitCode."
Expand Down
Loading
Loading