ci: run ruff check with --no-fix so autofixable violations fail - #224
Merged
krisztianfekete merged 1 commit intoSep 23, 2026
Merged
Conversation
pyproject.toml sets `fix = true` under [tool.ruff], so `ruff check .` in CI applied safe autofixes (import sorting, whitespace) to its own checkout and exited 0. The violations were never reported and nothing was committed, so they landed on main unfixed. Pass --no-fix in CI so these are reported and fail the job. `fix = true` stays in pyproject.toml for local development. Refs agentevals-dev#168
Contributor
Author
|
Hi, the fix is correct or do I have to change something here |
krisztianfekete
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the CI Ruff check to run with
--no-fix.The reason is that
pyproject.tomlhasfix = true, soruff check .in CI was silently fixing violations and exiting with code 0 instead of reporting them.Before, a file with unsorted imports could pass CI because Ruff fixed it automatically. Now, the same issue is reported as
I001and CI fails as expected.I also verified that the current repo passes both
ruff check --no-fix .andruff format --check ., so CI will remain green.AI was used to help with this change, as required by
CONTRIBUTING.md.Closes #168.