Closed
Conversation
Member
benbrandt
commented
Apr 14, 2026
- Restructure control flow
- cleanup error
- Cleanup and add test
2dc6411 to
ebd50c4
Compare
nikomatsakis
approved these changes
Apr 16, 2026
Contributor
nikomatsakis
left a comment
There was a problem hiding this comment.
I think this PR looks good. I like the tests. I'd be happy to merge it
However, I feel like the overall approach is kind of fragile. I feel like it'd be nice to just put ? in handlers and not have to think too hard. I wonder if what we ought to do instead is to change the way that we deal with errors from handlers (and maybe tasks and other user-supplied code) so that, instead of propagating them, we actually just swallow them and report them back to the other side? Kind of like how a web server will catch an unhandled exception and recover?
We could have some sentinel type for a "fatal error" that truly propagates out.
Member
Author
|
Closing in favor of #114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.