Repository navigation
fix: publish complete configuration updates for session changes - #715
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_option_updatewhen the advertised list changes, rather than duplicating publication in individual callers.session/set_config_option, the legacy mode/model setters, command-driven changes, approved-plan implementation, and provider/recovery model refreshes. The requesting client's duplicate notification is written before the setter response.Checked against ACP commit
854e6003.docs/protocol/v2/session-config-options.mdx:375-379recommends configuration notifications whenever configuration changes, including changes requested throughsession/set_config_option, with the requesting client's duplicate before its response. Responses and notifications replace the complete list.Scope
Based on the merged #714, not stacked on its feature branch. No review/checklist Markdown file is added. This covers configuration changes owned by the adapter; it does not add new native settings-event synchronization or change active-resume environment replacement. Remaining session/entity metadata reconstruction is separate.
Validation
npm run typechecknpm run buildnpm test: 2,332 passed, 39 skippednpm run test:integration: all 19 passednpm run codex-test -- -p "Reply with exactly OK. Do not use tools or modify any files." -o summary: completed withend_turngit diff --checkNew wire tests cover notification-before-response ordering for every root config option on both protocol versions, complete dependent model changes, no-op and rejected/native-failure cases, one notification for
/plan, legacy setters, and replay replacing the session during a pending native settings request. Existing command, plan, provider/recovery, and child configuration tests remain passing without snapshot updates.