Repository navigation
fix: suppress session messages after close - #712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up #711 with a publication fence for closed sessions on ACP v1 and v2.
Validation
npm run typecheck— passed, including examples.npm test— 2,293 passed, 39 skipped.npm run test:integration— all 19 passed across 8 files.npm run buildandgit diff --check— passed.npm run codex-test -- -p "Reply with exactly OK. Do not use tools or modify any files." -o summary— completed withend_turn.Wire regression coverage includes v1/v2, standard and AIR child views, close/delete, resume, direct v2 sends, URL completion, and a deliberately delayed inserted-prompt response. Existing notification-order snapshots are unchanged.
Remaining follow-ups
Resume snapshots and metadata resynchronization, setup-response ordering, configuration publication, subagent directories, and authentication/MCP delegation remain separate changes. Active-resume environment replacement still needs the protocol decision about in-flight operations using removed roots or MCP servers. No internal review document is included.